Repository navigation
chore: clean-up - #14338
Merged
kgryte merged 3 commits intoAug 17, 2026
Merged
chore: clean-up#14338
Conversation
…s/frechet/logpdf` The outer JSDoc leading description in `lib/factory.js` read "logarithm of the probability density function (PDF)", dropping the word "natural". The package's own `lib/main.js` description and the file's inner private-function JSDoc both say "natural logarithm", and the implementation uses `ln`, so "natural logarithm" is the accurate term. Restored "natural" to match, in line with the value-function siblings whose factory descriptions carry it (4/5).
…/frechet/pdf` Added the distribution-level keywords `weibull`, `inverse`, `extreme`, and `value` to `package.json`. Fréchet is the inverse Weibull / Type-II extreme value distribution, so these descriptors apply to `pdf` as to its siblings. Restores the canonical `frechet, weibull, inverse, extreme, value` keyword run shared by the sibling majority (`weibull`/`inverse`/`extreme`: 13/14; `value`: 12/14).
…et/quantile` Added the `value` keyword to `package.json`, completing the "extreme value" descriptor pair carried by the sibling majority (12/14). The package already carried `weibull`, `inverse`, and `extreme`; only `value` was missing.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
August 17, 2026 01:05
kgryte
approved these changes
Aug 17, 2026
@stdlib/stats/base/dists/frechet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request normalizes three metadata/documentation inconsistencies in
@stdlib/stats/base/dists/frechetwhere individual packages had drifted from the pattern shared by the rest of the namespace. No observable behavior, signatures, or test expectations change.Namespace summary.
stats/base/dists/frechethas 14 members (cdf,ctor,entropy,kurtosis,logcdf,logpdf,mean,median,mode,pdf,quantile,skewness,stdev,variance). Structural features (file tree,package.json/manifest.jsonshape, README section skeleton, test/benchmark/example naming) and semantic features (public signatures, return kind, validation prologue, error construction, JSDoc shape, dependencies) were extracted per package and compared at a 75% majority threshold (⌈14 × 0.75⌉ = 11). Features with a clear majority include the C-backed file layout,package.jsonstructure, the distribution-levelkeywordscluster, and JSDoc shape within each of the two sub-templates. Features without a clear majority — the value-function vs. property-function split (factory.js, extra fixtures),@returnstypes, per-function dependencies, and per-function example counts — were excluded from drift analysis as semantically justified.Three outliers cleared structural, semantic, and cross-reference validation:
pdfpdf/package.jsoncarried onlyfrechetfrom the distribution-level keyword cluster, droppingweibull,inverse,extreme, andvalue. Fréchet is the inverse Weibull / Type-II extreme value distribution, so these are distribution-level descriptors, not function-specific ones:weibull/inverse/extremeappear in 13/14 members andvaluein 12/14. Restored the canonicalfrechet, weibull, inverse, extreme, valuerun.quantilequantile/package.jsonalready carriedweibull,inverse, andextremebut omittedvalue, splitting the "extreme value" descriptor that the sibling majority keeps intact (12/14). Addedvalueafterextreme.logpdfThe outer JSDoc description in
logpdf/lib/factory.jsread "logarithm of the probability density function (PDF)", dropping "natural". The package's ownlib/main.jsand the file's inner private-function JSDoc both say "natural logarithm", the implementation usesln, and 4/5 value-function siblings carry "natural" in their factory descriptions. Restored "natural" to match.Related Issues
None.
Questions
No.
Other
Corrections are grouped one commit per package for a per-package audit trail. Validation: each candidate passed a three-part review — a semantic review (intentional deviation vs. unintentional drift), a cross-reference review (no test, example, benchmark, or doctest pins the changed strings;
keywordsis never imported and the JSDoc text appears only in source/type/header files), and a structural review confirming the majority pattern is the one that should apply. Deliberately excluded:ctor(a pure-JS distribution class that legitimately lacks C infrastructure,manifest.json, and the## C APIssection — a different package kind, not drift); the value-function/property-function sub-template differences; andmean/README.md, whose linked, qualified prose ([expected value][mean],α > 0) is used consistently throughout that README and is a stylistic choice rather than a mechanical one-line deviation.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was prepared with Claude Code: it extracted structural and semantic features across the
frechetnamespace, identified the majority pattern per feature, flagged the three deviating packages, and drafted the metadata/documentation corrections. Each correction was validated against the sibling majority and checked to ensure no tests or examples depend on the changed strings. A human should review before merge.🤖 Generated with Claude Code
https://claude.ai/code/session_01L6FX3YNHq4yikJPVcoQDra
Generated by Claude Code