Repository navigation
feat: add C implementation for blas/ext/base/ndarray/dnansumkbn2 - #14333
Open
Shravani-Relekar wants to merge 3 commits into
Open
Shravani-Relekar wants to merge 3 commits into
Shravani-Relekar wants to merge 3 commits into
Conversation
stdlib-bot
added
BLAS
kgryte
added
Feature
Member
|
@ujjwalv01 Mind taking a first review on this PR? Cheers! |
ujjwalv01
reviewed
Aug 23, 2026
Member
Done! Just left one small formatting suggestion on the README. Everthing else looks good; |
…DME.md Co-authored-by: Ujjwal Verma <ujjwalverma010305@gmail.com> Signed-off-by: Shravani-Relekar <shravanirelekar@gmail.com>
Contributor
Coverage ReportNo coverage information available. |
Member
|
@Shravani-Relekar Worth doing another review, as CI is showing failing tests. Note that the native addon tests should be almost identical to the JS API tests with minor modifications. |
kgryte
added
Needs Changes
Author
|
hey @kgryte ! i have addressed the changes , can you please take a review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
blas/ext/base/ndarray/dnansumkbn2Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
@stdlib-js/reviewers