Skip to content

docs: fix note - #14290

Merged
kgryte merged 3 commits into
developfrom
philipp/fix-commit-review-2026-08-15
Aug 15, 2026
Merged

kgryte merged 3 commits into
developfrom
philipp/fix-commit-review-2026-08-15

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request contains follow-up fixes for commits merged to develop between 2026-08-14T13:55:13-07:00 (75cbfe86) and 2026-08-15T04:48:58-07:00 (086aa4d2). All 31 commits in the window were reviewed for typos, bugs, and style-guide violations; two documentation fixes resulted.

This pull request:

  • fft/base/fftpack/rfftf: Fix dangling link in lib/node_modules/@stdlib/fft/base/fftpack/rfftf/README.md (086aa4d): rfftb doesn't exist as a package, so drop the [backward transform][@stdlib/fft/base/fftpack/rfftb] markup and the orphaned link definition, keep the plain-text reference.
  • blas/ext/base/ndarray/clogspace: Fixed leftover dlogspace template text in lib/node_modules/@stdlib/blas/ext/base/ndarray/clogspace/README.md (3d73475): Notes section referenced arr[1], but the example only defines v. Changed to v to match zlogspace.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Review window: 31 commits merged to develop in the 24 hours preceding 2026-08-15, spanning new fft/base/fftpack packages (rfftf, ndarray/rffti), five new stats/base/ndarray/dvariance* kernels, native C backing for dnanmidrange/dnanmeanwd, new single-precision math/base/special functions (expm1f, exp2f, cfloornf), BLAS additions (ssymv, clogspace, zlogspace), nine ULP-based test migrations, and CI/docs housekeeping.

Validation performed:

  • Style-guide compliance audit (two independent passes) against docs/style-guides and established sibling packages of comparable complexity.
  • Bug scan (two independent passes) over the union diff and per-commit diffs, including execution of new kernels against reference implementations (rfftf vs. brute-force DFT and shipped C fixtures; exp2f/expm1f vs. FreeBSD msun references and Julia fixtures; JS vs. C parity checks). No runtime defects found.

Deliberately excluded: subjective suggestions, style preferences not explicitly required by the style guides, and anything requiring interpretation. Notably, fft/base/fftpack/ndarray/rffti describing its workspace argument as "a one-dimensional input ndarray" was flagged and dropped: pre-existing siblings (blas/ext/base/ndarray/dlogspace, glogspace) use identical wording for mutated destination ndarrays, so this is established convention. Runtime namespace registrations without matching docs/types/index.d.ts entries (098f2aa, bc5638e) were likewise not flagged, as batched TypeScript declaration updates are the normal workflow.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude Code as part of an automated review of commits recently merged to develop. Claude Code identified the documentation errors, applied the fixes, and drafted this PR for human audit and promotion.


Generated by Claude Code

@stdlib-bot

stdlib-bot commented Aug 15, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/ndarray/clogspace $\\color{green}157/157$
$\\color{green}+0.00\\%$
$\\color{green}3/3$
$\\color{green}+0.00\\%$
$\\color{green}1/1$
$\\color{green}+0.00\\%$
$\\color{green}157/157$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Aug 15, 2026
@kgryte
kgryte marked this pull request as ready for review August 15, 2026 12:50
@kgryte
kgryte requested a review from a team August 15, 2026 12:50
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 15, 2026
@kgryte kgryte added Documentation Improvements, additions, or changes to documentation. and removed Needs Review A pull request which needs code review. labels Aug 15, 2026
@kgryte kgryte changed the title docs: fix README copy-paste errors in fft/base/fftpack/rfftf and blas/ext/base/ndarray/clogspace docs: fix note Aug 15, 2026
@kgryte
kgryte merged commit 8d4d135 into develop Aug 15, 2026
63 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-08-15 branch August 15, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Documentation Improvements, additions, or changes to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants