Repository navigation
test: migrate math/base/special/atan2f to ULP-based assertions - #14178
Merged
Merged
Conversation
Replaces relative-tolerance comparisons in the fixture-driven test cases with `isAlmostSameValue` checks expressed in ULPs, mirroring the approach used for `math/base/special/atan2d`. Ref: #11352 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GxDGtL3RkuPzo2Wp3V97rB --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Aug 11, 2026
3 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/atan2ftest cases from relative-tolerance testing to ULP (units in the last place) difference testing, per the guidance in [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.delta/tolrelative-tolerance checks in the three fixture-driven test cases (xandyboth positive;xnegative,ypositive;xandyboth negative) intest/test.jsandtest/test.native.jswitht.strictEqual( isAlmostSameValue( actual, expected[ i ], N ), true, 'returns expected value' ), using@stdlib/number/float32/base/assert/is-almost-same-value(matching the convention used by siblingfloat32functions such asatanfandhypotf).positivePositive→ 2 ULPs (5001 cases),negativePositive→ 1 ULP (1001 cases),negativeNegative→ 1 ULP (1001 cases). Bothtest.jsandtest.native.jsuse the same bounds, mirroring the recently convertedmath/base/special/atan2d(same underlying algorithm, JS vs. native).absf/EPSimports.Verified:
node test/test.jspasses 7062/7062 assertions at the tightened bounds, run twice back-to-back with identical results (no flakiness).npx eslintis clean on both changed files. The native addon is not built in this environment, sotest.native.jsULPs were set to match the JS bounds (same as theatan2dprecedent) rather than independently measured;test.native.jsassertions are skipped (not failed) when the addon is absent.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored end-to-end by Claude Code, run as a scheduled/unattended task on my account. It found the candidate package, studied prior art (issue #11352 and the
atan2dconversion), applied the ULP migration, computed the tightest ULP bounds directly from the fixtures, and verified tests/lint pass. Opened as a draft so I can review before it goes further.@stdlib-js/reviewers
Generated by Claude Code