Repository navigation
test: migrate math/base/special/cospi to ULP-based assertions - #14153
Conversation
Replaces relative-tolerance comparisons in the fixture-driven test with `@stdlib/assert/is-almost-same-value`, matching the pattern established for other `math/base/special` packages. Ref: #11352 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RXRe7DKMnJDk6MHLbuqWgk --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: skipped - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
|
Hello! 👋 We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm! Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks. Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀 For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Resolves a part of #11352.
Description
This pull request:
math/base/special/cospipackage tests from relative-tolerance (delta/tol/EPS) comparisons to ULP-based assertions using@stdlib/assert/is-almost-same-value, per the tracking issue.test/test.jsandtest/test.native.js, each of which had a single fixture-driven test block ('the function computes cos(πx)') using the old idiom.1passes reliably for both the JS and native implementations, while0(exact equality) fails (380 of 6214 cases). The test suite was run twice at ULP1for both files to confirm deterministic results.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, run as an unattended scheduled task. It searched the repository for a package still using the old relative-tolerance test idiom, cross-checked existing open/merged ULP-migration PRs to avoid duplicating work, studied prior-art commits (e.g. the
atan2d,powm1, andcceilnconversions) to mirror the established idiom, converted the tolerance checks toisAlmostSameValue, and empirically determined the minimum passing ULP bound by testing both1and0and confirming determinism across repeated runs.@stdlib-js/reviewers
Generated by Claude Code