Repository navigation
chore: clean-up - #14136
Merged
Merged
chore: clean-up#14136
Conversation
- Replace copied `should return an ndarray` failure message in the benchmark NaN guard with `should not return NaN` to match sibling packages. - Fix example indentation in TypeScript declarations.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
August 10, 2026 20:55
kgryte
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request contains follow-up fixes for commits merged to
developbetweenb3d9447(2026-08-09 06:03 PT) andaf0c6b6(2026-08-10 05:41 PT).This pull request:
blas/ext/base/ccopy-within: fixes float literal suffixes forx[]in ccopy-within (f24cab5): the README.md examples (three blocks) and examples/c/example.c initialize afloat x[]with unsuffixed1.0/2.0doubles instead of1.0f/2.0f, inconsistent with scopy-within/caxpy and every other single-precision sibling.blas/ext/base/ndarray/ctriu: fixes a copy-paste error message in thectriubenchmark's NaN guard, introduced in 375701a:lib/node_modules/@stdlib/blas/ext/base/ndarray/ctriu/benchmark/benchmark.js:88says'should return an ndarray'but should say'should not return NaN', matching the identical guard ingtriu/ztriu/striufrom the same batch.blas/ext/base/ndarray/{gtriu,ctriu,ztriu,striu}: fixes a docstring indentation issue indocs/types/index.d.ts(line 47) across all four packages: the'dtype': 'generic'line under@exampleused four spaces after the*instead of five, out of step with each package'slib/main.jsand every otherblas/ext/base/ndarraydeclaration file. Introduced in 9f9dfc5, 375701a, a6dc0eb, and 5bab5d6 respectively; the fix adds the missing space in all four files.Related Issues
No.
Questions
No.
Other
Validation. All 36 commits merged to
developin the 24-hour window were reviewed for bugs and for compliance with the guidelines indocs/style-guides, with new packages compared against established sibling packages of similar functionality (e.g.,scopy-within,gfill-equal,dtriu,secf,round10). Each finding above was independently re-verified against the diff and the currentdevelopcheckout before a fix was committed. Deliberately excluded: subjective concerns, style preferences not required by the style guides, and anything requiring interpretation or changes outside the reviewed diff (one candidate finding — operator spacing inmath/base/special/acschf— was rejected as a false positive, asspace-infix-opsis disabled in the project ESLint configuration and established siblings such asacothfuse the same spacing).Note: this is a draft PR intended for maintainer audit before promotion.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of a scheduled automated review of commits merged to
developin the preceding 24 hours. Findings were generated and cross-checked by multiple independent review passes, re-verified against sibling packages, and the fixes were applied and committed by Claude Code.Generated by Claude Code