Skip to content

chore: clean-up - #14136

Merged
kgryte merged 5 commits into
developfrom
philipp/fix-commit-review-2026-08-10
Aug 10, 2026
Merged

kgryte merged 5 commits into
developfrom
philipp/fix-commit-review-2026-08-10

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request contains follow-up fixes for commits merged to develop between b3d9447 (2026-08-09 06:03 PT) and af0c6b6 (2026-08-10 05:41 PT).

This pull request:

  • blas/ext/base/ccopy-within: fixes float literal suffixes for x[] in ccopy-within (f24cab5): the README.md examples (three blocks) and examples/c/example.c initialize a float x[] with unsuffixed 1.0/2.0 doubles instead of 1.0f/2.0f, inconsistent with scopy-within/caxpy and every other single-precision sibling.
  • blas/ext/base/ndarray/ctriu: fixes a copy-paste error message in the ctriu benchmark's NaN guard, introduced in 375701a: lib/node_modules/@stdlib/blas/ext/base/ndarray/ctriu/benchmark/benchmark.js:88 says 'should return an ndarray' but should say 'should not return NaN', matching the identical guard in gtriu/ztriu/striu from the same batch.
  • blas/ext/base/ndarray/{gtriu,ctriu,ztriu,striu}: fixes a docstring indentation issue in docs/types/index.d.ts (line 47) across all four packages: the 'dtype': 'generic' line under @example used four spaces after the * instead of five, out of step with each package's lib/main.js and every other blas/ext/base/ndarray declaration file. Introduced in 9f9dfc5, 375701a, a6dc0eb, and 5bab5d6 respectively; the fix adds the missing space in all four files.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation. All 36 commits merged to develop in the 24-hour window were reviewed for bugs and for compliance with the guidelines in docs/style-guides, with new packages compared against established sibling packages of similar functionality (e.g., scopy-within, gfill-equal, dtriu, secf, round10). Each finding above was independently re-verified against the diff and the current develop checkout before a fix was committed. Deliberately excluded: subjective concerns, style preferences not required by the style guides, and anything requiring interpretation or changes outside the reviewed diff (one candidate finding — operator spacing in math/base/special/acschf — was rejected as a false positive, as space-infix-ops is disabled in the project ESLint configuration and established siblings such as acothf use the same spacing).

Note: this is a draft PR intended for maintainer audit before promotion.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude Code as part of a scheduled automated review of commits merged to develop in the preceding 24 hours. Findings were generated and cross-checked by multiple independent review passes, re-verified against sibling packages, and the fixes were applied and committed by Claude Code.


Generated by Claude Code

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Aug 10, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/ccopy-within $\\color{green}415/415$
$\\color{green}+100.00\\%$
$\\color{green}22/22$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}415/415$
$\\color{green}+100.00\\%$
blas/ext/base/ndarray/ctriu $\\color{green}139/139$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}139/139$
$\\color{green}+100.00\\%$
blas/ext/base/ndarray/gtriu $\\color{green}139/139$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}139/139$
$\\color{green}+100.00\\%$
blas/ext/base/ndarray/striu $\\color{green}139/139$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}139/139$
$\\color{green}+100.00\\%$
blas/ext/base/ndarray/ztriu $\\color{green}139/139$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}139/139$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte
kgryte marked this pull request as ready for review August 10, 2026 20:55
@kgryte
kgryte requested a review from a team August 10, 2026 20:55
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 10, 2026
@kgryte kgryte changed the title fix: address review findings from commits recently merged to develop chore: clean-up Aug 10, 2026
@kgryte
kgryte merged commit 362ed23 into develop Aug 10, 2026
54 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-08-10 branch August 10, 2026 20:55
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Aug 10, 2026
@kgryte kgryte added the Documentation Improvements, additions, or changes to documentation. label Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Documentation Improvements, additions, or changes to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants