Repository navigation
test: migrate math/base/special/asinf to ULP-based testing - #14111
Conversation
|
Hello! 👋 We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm! Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks. Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀 For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Resolves a part of #11352.
Description
This pull request:
math/base/special/asinffrom computed relative tolerance (EPS-scaleddelta <= tol) checks to ULP-based assertions;@stdlib/math/base/special/absrequire with@stdlib/number/float32/base/assert/is-almost-same-value. (TheEPSconstant is retained as it is utilized for boundary generation tests).test/test.jsandtest/test.native.jsare modified to use the new ULP assertions.ULP bounds (one per fixture set, each tightened to the measured minimum):
data3.3 * EPS5small_negative1.0 * EPS0small_positive1.0 * EPS0Each bound is the smallest non-negative integer for which every fixture in the corresponding set passes. Starting from a high bound and lowering, the suite passes at the values above (8014/8014 assertions), and decrementing each bound by one produces exactly one failure per set, confirming that no bound can be tightened further.
Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers