Skip to content

chore: clean-up - #14098

Merged
kgryte merged 2 commits into
developfrom
philipp/fix-commit-review-2026-08-09
Aug 9, 2026
Merged

kgryte merged 2 commits into
developfrom
philipp/fix-commit-review-2026-08-09

Conversation

@Planeshifter

@Planeshifter Planeshifter commented Aug 9, 2026 •

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes for commits merged to develop between ebbf2de9 (2026-08-08 06:00 PT) and 9bd464a4 (2026-08-09 05:04 PT).

This pull request:

  • number/int64/base/identity
    • Fixes %ld → PRId64 in lib/node_modules/@stdlib/number/int64/base/identity/examples/c/example.c (introduced in 5a6af33): int64_t is long long on LLP64/32-bit, so the mismatched conversion specifier is UB and trips -Wformat. Brings it in line with every other C example that prints 64-bit ints.
    • In commit 5a6af33, the C "Examples" section in lib/node_modules/@stdlib/number/int64/base/identity/README.md prints int64_t values with %ld, mirroring the non-portable format specifier fixed in examples/c/example.c. Updates the README snippet to include inttypes.h and use PRId64 so it doesn't hand LLP64/32-bit users undefined behavior when they copy it.
  • ml/base/sgd/params/struct-factory
    • lib/node_modules/@stdlib/ml/base/sgd/params/struct-factory/README.md#L65 has a stray extra colon in the l1 bullet under penaltyParams (**l1**: :), introduced in 9bd464a. Drops the duplicate so it matches every other bullet and the l1 entry in docs/types/index.d.ts.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation. All 30 commits merged to develop in the window were reviewed for (1) stdlib style-guide compliance (compared against established sibling packages, e.g. dtril, sfill-equal, ztril, dcopy-within, cexp) and (2) objective bugs in the introduced code (loop/stride arithmetic, complex real/imag handling, int64 word handling, JS↔C implementation parity, README/repl.txt example outputs recomputed by hand, affected test suites executed). Only objective, independently re-verified issues are included; the fixed printf pattern was compile-checked with -Wall -Wformat -Werror.

Deliberately excluded: anything subjective or requiring interpretation, deliberate authorial choices (round-nearest-even change in rempio2/rempio2f, per-function ULP tolerances in migrated tests, VLA→malloc benchmark refactor), and one candidate finding (missing __stdlib__ field in blas/ext/base/gtril2triu/package.json) dropped because 49 of 389 sibling packages — including the entire pre-existing gtril/gtriu/gtriu2tril family — omit the field, so the convention is not unambiguous.

Note: this is a draft PR; a maintainer will audit and promote it.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was produced by a scheduled Claude Code review routine: Claude reviewed the last 24 hours of commits merged to develop, validated candidate findings against the repository, and authored the fixes and this PR description. All changes are pending human audit (hence draft status).

@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
ml/base/sgd/params/struct-factory $\\color{green}154/154$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}154/154$
$\\color{green}+100.00\\%$
number/int64/base/identity $\\color{green}189/189$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}189/189$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte
kgryte marked this pull request as ready for review August 9, 2026 13:03
@kgryte
kgryte requested a review from a team August 9, 2026 13:03
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 9, 2026
@kgryte kgryte changed the title fix: apply follow-up fixes from review of recently merged commits chore: clean-up Aug 9, 2026
@kgryte
kgryte merged commit b3d9447 into develop Aug 9, 2026
40 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-08-09 branch August 9, 2026 13:04
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants