Repository navigation
chore: clean-up - #14098
Merged
Merged
chore: clean-up#14098
Conversation
…xamples Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E2Zn33Ra7ZacEpKJKVXi2f
…README Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E2Zn33Ra7ZacEpKJKVXi2f
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
August 9, 2026 13:03
kgryte
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetweenebbf2de9(2026-08-08 06:00 PT) and9bd464a4(2026-08-09 05:04 PT).This pull request:
number/int64/base/identity%ld→PRId64inlib/node_modules/@stdlib/number/int64/base/identity/examples/c/example.c(introduced in 5a6af33):int64_tislong longon LLP64/32-bit, so the mismatched conversion specifier is UB and trips-Wformat. Brings it in line with every other C example that prints 64-bit ints.lib/node_modules/@stdlib/number/int64/base/identity/README.mdprintsint64_tvalues with%ld, mirroring the non-portable format specifier fixed inexamples/c/example.c. Updates the README snippet to includeinttypes.hand usePRId64so it doesn't hand LLP64/32-bit users undefined behavior when they copy it.ml/base/sgd/params/struct-factorylib/node_modules/@stdlib/ml/base/sgd/params/struct-factory/README.md#L65has a stray extra colon in thel1bullet underpenaltyParams(**l1**: :), introduced in 9bd464a. Drops the duplicate so it matches every other bullet and thel1entry indocs/types/index.d.ts.Related Issues
No.
Questions
No.
Other
Validation. All 30 commits merged to
developin the window were reviewed for (1) stdlib style-guide compliance (compared against established sibling packages, e.g.dtril,sfill-equal,ztril,dcopy-within,cexp) and (2) objective bugs in the introduced code (loop/stride arithmetic, complex real/imag handling, int64 word handling, JS↔C implementation parity, README/repl.txt example outputs recomputed by hand, affected test suites executed). Only objective, independently re-verified issues are included; the fixedprintfpattern was compile-checked with-Wall -Wformat -Werror.Deliberately excluded: anything subjective or requiring interpretation, deliberate authorial choices (round-nearest-even change in
rempio2/rempio2f, per-function ULP tolerances in migrated tests, VLA→mallocbenchmark refactor), and one candidate finding (missing__stdlib__field inblas/ext/base/gtril2triu/package.json) dropped because 49 of 389 sibling packages — including the entire pre-existinggtril/gtriu/gtriu2trilfamily — omit the field, so the convention is not unambiguous.Note: this is a draft PR; a maintainer will audit and promote it.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was produced by a scheduled Claude Code review routine: Claude reviewed the last 24 hours of commits merged to
develop, validated candidate findings against the repository, and authored the fixes and this PR description. All changes are pending human audit (hence draft status).