Repository navigation
chore: clean-up - #14014
Merged
Merged
chore: clean-up#14014
Conversation
kgryte
reviewed
Aug 7, 2026
| # @param {string} [TESTS_FILTER] - file path pattern (e.g., `.*/doctest/compare-values/.*`) | ||
| # @param {string} [JAVASCRIPT_CODE_INSTRUMENTER] - JavaScript code instrumenter | ||
| # @param {*} [FAST_FAIL] - flag indicating whether to stop running tests upon encountering a test failure | ||
| # @param {*} [FAIL_FAST] - flag indicating whether to stop running tests upon encountering a test failure |
Member
There was a problem hiding this comment.
This is wrong. The user-facing environment variable is FAST_FAIL. See
Line 40 in 8500b0f
Member
Author
There was a problem hiding this comment.
You're right — FAST_FAIL is the user-facing variable and FAIL_FAST is the derived internal flag, so the original docstring was correct. Thanks for reverting. The actual inconsistency was the other way around: the new tools-test-cov/c8.mk docstring documented FAIL_FAST, unlike test-cov/c8.mk and istanbul.mk which document FAST_FAIL. Fixed in a2f1fa0.
Generated by Claude Code
kgryte
marked this pull request as ready for review
August 7, 2026 22:57
kgryte
previously approved these changes
Aug 7, 2026
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-08-06 08:33 (-0700) (37d7d9e) and 2026-08-07 04:52 (-0700) (9e08b03).This pull request:
stats/base/dists/arcsine/cdf: Fix typo 'retruns' -> 'returns' in the assertion messages left by 7b64d86's ULP-based test migration forstats/base/dists/arcsine/cdf; corrected intest/test.main.js:138andtest/test.native.js:109.tools/make/lib/tools-test-cov: docstring intools/make/lib/tools-test-cov/c8.mk(introduced fbe844b) documents the internalFAIL_FASTflag; the user-facing environment variable — documented by the siblingtest-cov/c8.mkandistanbul.mkdocstrings — isFAST_FAIL(seetools/make/common.mk). Corrected the docstring. (An earlier commit on this branch wrongly "fixed"javascript.mkin the opposite direction; that change was reverted.)blas/ext/base/ztril: Fixblas/ext/base/ztril/test/test.js:26—require( './../lib/' )had a stray trailing slash, out of step with every other package test (see siblingztriu); dropped it to match convention. Originated in 41d170f.assert/has-promise-support: Indocs/repl.txt, commit 258e932 (assert/has-promise-support) left a stray trailing blank line after See Also, inconsistent withhas-async-await-support,has-generator-support, andhas-symbol-support; trimmed to match.Related Issues
No.
Questions
No.
Other
Validation. All 39 commits merged to
developin the 24-hour window were reviewed for typos, bugs, and stdlib style-guide violations. Checks performed: style-guide compliance of new packages (blas/ext/base/ztril,blas/ext/base/gtriu2tril,blas/ext/base/ndarray/{d,g,s}copy-within,stats/base/ndarray/dmeanliC add-on,assert/has-promise-support) against established sibling packages; a bug scan of the full union diff (C kernel loop bounds, napi argument marshalling, complex stride handling, memory allocation/free paths, ULP tolerance migrations, CI workflow guard logic). No runtime bugs were found; the migrated ULP-based test suites all pass.Deliberately excluded (anything requiring interpretation): missing namespace TypeScript declarations / README TOC entries for the newly added packages (
ztril,gtriu2tril,dcopyWithin/gcopyWithin/scopyWithin,hasPromiseSupport) — these land in separate follow-up commits per established repo practice (cf. 6545980 in this same window); and any subjective or judgment-call findings.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated review of commits recently merged to
develop. Claude reviewed the diffs, validated each finding against sibling packages and style guides, and applied the fixes; a human maintainer will audit before promoting from draft.