Skip to content

chore: clean-up - #14014

Merged
kgryte merged 6 commits into
developfrom
philipp/fix-commit-review-2026-08-07
Aug 7, 2026
Merged

kgryte merged 6 commits into
developfrom
philipp/fix-commit-review-2026-08-07

Conversation

@Planeshifter

@Planeshifter Planeshifter commented Aug 7, 2026 •

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes for commits merged to develop between 2026-08-06 08:33 (-0700) (37d7d9e) and 2026-08-07 04:52 (-0700) (9e08b03).

This pull request:

  • stats/base/dists/arcsine/cdf: Fix typo 'retruns' -> 'returns' in the assertion messages left by 7b64d86's ULP-based test migration for stats/base/dists/arcsine/cdf; corrected in test/test.main.js:138 and test/test.native.js:109.
  • tools/make/lib/tools-test-cov: docstring in tools/make/lib/tools-test-cov/c8.mk (introduced fbe844b) documents the internal FAIL_FAST flag; the user-facing environment variable — documented by the sibling test-cov/c8.mk and istanbul.mk docstrings — is FAST_FAIL (see tools/make/common.mk). Corrected the docstring. (An earlier commit on this branch wrongly "fixed" javascript.mk in the opposite direction; that change was reverted.)
  • blas/ext/base/ztril: Fix blas/ext/base/ztril/test/test.js:26 — require( './../lib/' ) had a stray trailing slash, out of step with every other package test (see sibling ztriu); dropped it to match convention. Originated in 41d170f.
  • assert/has-promise-support: In docs/repl.txt, commit 258e932 (assert/has-promise-support) left a stray trailing blank line after See Also, inconsistent with has-async-await-support, has-generator-support, and has-symbol-support; trimmed to match.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation. All 39 commits merged to develop in the 24-hour window were reviewed for typos, bugs, and stdlib style-guide violations. Checks performed: style-guide compliance of new packages (blas/ext/base/ztril, blas/ext/base/gtriu2tril, blas/ext/base/ndarray/{d,g,s}copy-within, stats/base/ndarray/dmeanli C add-on, assert/has-promise-support) against established sibling packages; a bug scan of the full union diff (C kernel loop bounds, napi argument marshalling, complex stride handling, memory allocation/free paths, ULP tolerance migrations, CI workflow guard logic). No runtime bugs were found; the migrated ULP-based test suites all pass.

Deliberately excluded (anything requiring interpretation): missing namespace TypeScript declarations / README TOC entries for the newly added packages (ztril, gtriu2tril, dcopyWithin/gcopyWithin/scopyWithin, hasPromiseSupport) — these land in separate follow-up commits per established repo practice (cf. 6545980 in this same window); and any subjective or judgment-call findings.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude Code as part of an automated review of commits recently merged to develop. Claude reviewed the diffs, validated each finding against sibling packages and style guides, and applied the fixes; a human maintainer will audit before promoting from draft.

# @param {string} [TESTS_FILTER] - file path pattern (e.g., `.*/doctest/compare-values/.*`)
# @param {string} [JAVASCRIPT_CODE_INSTRUMENTER] - JavaScript code instrumenter
# @param {*} [FAST_FAIL] - flag indicating whether to stop running tests upon encountering a test failure
# @param {*} [FAIL_FAST] - flag indicating whether to stop running tests upon encountering a test failure

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. The user-facing environment variable is FAST_FAIL. See

ifndef FAST_FAIL
.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right — FAST_FAIL is the user-facing variable and FAIL_FAST is the derived internal flag, so the original docstring was correct. Thanks for reverting. The actual inconsistency was the other way around: the new tools-test-cov/c8.mk docstring documented FAIL_FAST, unlike test-cov/c8.mk and istanbul.mk which document FAST_FAIL. Fixed in a2f1fa0.


Generated by Claude Code

@kgryte
kgryte marked this pull request as ready for review August 7, 2026 22:57
@kgryte
kgryte requested a review from a team August 7, 2026 22:57
kgryte
kgryte previously approved these changes Aug 7, 2026
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 7, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
assert/has-promise-support $\\color{green}116/116$
$\\color{green}+100.00\\%$
$\\color{red}6/7$
$\\color{green}+85.71\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}116/116$
$\\color{green}+100.00\\%$
blas/ext/base/ztril $\\color{green}584/584$
$\\color{green}+100.00\\%$
$\\color{green}43/43$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}584/584$
$\\color{green}+100.00\\%$
stats/base/dists/arcsine/cdf $\\color{green}317/317$
$\\color{green}+100.00\\%$
$\\color{green}27/27$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}317/317$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte changed the title chore: follow-up fixes for commits merged to develop (2026-08-06/07 review window) chore: clean-up Aug 7, 2026
@kgryte
kgryte merged commit b149fa7 into develop Aug 7, 2026
15 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-08-07 branch August 7, 2026 23:14
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants