Skip to content

test: migrate math/base/special/powm1 to ULP-based testing #13983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 2 commits into from
Aug 6, 2026
Merged

test: migrate math/base/special/powm1 to ULP-based testing #13983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6325a9f
test(math/base/special/powm1): migrate relative tolerance check to ULP
ujjwalv01 Aug 6, 2026
21619f4
Apply suggestions from code review
kgryte Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions lib/node_modules/@stdlib/math/base/special/powm1/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,11 @@
// MODULES //

var tape = require( 'tape' );
var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var randu = require( '@stdlib/random/base/randu' );
var abs = require( '@stdlib/math/base/special/abs' );
var expm1 = require( '@stdlib/math/base/special/expm1' );
var ln = require( '@stdlib/math/base/special/ln' );
var EPS = require( '@stdlib/constants/float64/eps' );
var randu = require( '@stdlib/random/base/randu' );
var powm1 = require( './../lib' );


Expand Down Expand Up @@ -72,8 +71,6 @@ tape( 'if provided a base equal to `0`, the function returns `-1` (except when t

tape( 'the function evaluates `bˣ - 1` (tested against Boost)', function test( t ) {
var expected;
var delta;
var tol;
var b;
var x;
var y;
Expand All @@ -85,9 +82,7 @@ tape( 'the function evaluates `bˣ - 1` (tested against Boost)', function test(

for ( i = 0; i < b.length; i++ ) {
y = powm1( b[ i ], x[ i ] );
delta = abs( y - expected[ i ] );
tol = 2.0 * EPS * abs( expected[ i ] );
t.ok( delta <= tol, 'within tolerance. b: ' + b[ i ] + 'x: ' + x[ i ] + '. actual: ' + y + '. E: ' + expected[ i ] + '. tol: ' + tol + '. Δ: ' + delta + '.' );
t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' );
}
t.end();
});
Expand Down
11 changes: 3 additions & 8 deletions lib/node_modules/@stdlib/math/base/special/powm1/test/test.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,11 @@

var resolve = require( 'path' ).resolve;
var tape = require( 'tape' );
var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var randu = require( '@stdlib/random/base/randu' );
var abs = require( '@stdlib/math/base/special/abs' );
var expm1 = require( '@stdlib/math/base/special/expm1' );
var ln = require( '@stdlib/math/base/special/ln' );
var EPS = require( '@stdlib/constants/float64/eps' );
var randu = require( '@stdlib/random/base/randu' );
var tryRequire = require( '@stdlib/utils/try-require' );


Expand Down Expand Up @@ -81,8 +80,6 @@ tape( 'if provided a base equal to `0`, the function returns `-1` (except when t

tape( 'the function evaluates `bˣ - 1` (tested against Boost)', opts, function test( t ) {
var expected;
var delta;
var tol;
var b;
var x;
var y;
Expand All @@ -94,9 +91,7 @@ tape( 'the function evaluates `bˣ - 1` (tested against Boost)', opts, function

for ( i = 0; i < b.length; i++ ) {
y = powm1( b[ i ], x[ i ] );
delta = abs( y - expected[ i ] );
tol = 2.0 * EPS * abs( expected[ i ] );
t.ok( delta <= tol, 'within tolerance. b: ' + b[ i ] + 'x: ' + x[ i ] + '. actual: ' + y + '. E: ' + expected[ i ] + '. tol: ' + tol + '. Δ: ' + delta + '.' );
t.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' );
}
t.end();
});
Expand Down
Loading