Skip to content

chore: clean-up - #13976

Merged
kgryte merged 2 commits into
developfrom
philipp/fix-commit-review-2026-08-06
Aug 6, 2026
Merged

kgryte merged 2 commits into
developfrom
philipp/fix-commit-review-2026-08-06

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes for commits merged to develop between 2026-08-05 21:23 (-0500) and 2026-08-06 04:04 (-0700) (1d04bde84..e1cc737f7, 26 commits).

This pull request:

  • blas/ext/base/dtriu2tril: Tighten pointer-offset spacing in dtriu2tril/src/main.c (5968644): B[ ib + ( i0*strideB1 ) ] → B[ ib+(i0*strideB1) ] on the two ndarray-loop lines in lib/node_modules/@stdlib/blas/ext/base/dtriu2tril/src/main.c, matching striu2tril and the rest of blas/ext/base.
  • math/base/special/frexpf: Fix leftover redundant f32() wrapping in math/base/special/frexpf/test/test.native.js:171 that 37facc3 missed — x = f32( sign * frac * f32( powf( 10.0, exp ) ) ) becomes x = f32( sign * frac * powf( 10.0, exp ) ), matching the five sites already migrated in that commit. No behavior change, powf already returns single precision.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation performed on the 24-hour commit window:

  • Style-guide compliance audit of the five new packages (blas/ext/base/dtriu2tril, blas/ext/base/striu2tril, ml/base/loss/float64/huber-gradient, ml/base/loss/float64/log-gradient, stats/base/dists/wald/mgf) against established sibling packages.
  • Bug scan of all changed code: triangular-copy index arithmetic in dtriu2tril/striu2tril (lib/base.js and src/main.c) brute-force verified against an independent reference over both memory layouts and diagonal offsets; Huber/log-loss gradient formulas and the Wald MGF (incl. domain guard) recomputed against their documented definitions and Julia fixtures; ULP-based test migrations spot-checked against prior tolerances. No runtime bugs found.
  • Deliberately excluded: anything subjective, anything requiring interpretation, and mechanical changes (ULP tolerance constants, bot-driven equation URL bumps).

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was produced by a scheduled Claude Code review of commits merged to develop in the last 24 hours; Claude identified the issues and authored the fixes, which await human audit (hence draft status).


🤖 Generated with Claude Code

https://claude.ai/code/session_01BDTnN9SGCH168sPZU4kXan


Generated by Claude Code

@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dtriu2tril $\\color{green}562/562$
$\\color{green}+100.00\\%$
$\\color{green}43/43$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}562/562$
$\\color{green}+100.00\\%$
math/base/special/frexpf $\\color{green}328/328$
$\\color{green}+100.00\\%$
$\\color{green}11/11$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}328/328$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter
Planeshifter marked this pull request as ready for review August 6, 2026 15:44
@Planeshifter
Planeshifter requested review from a team and kgryte August 6, 2026 15:44

Copy link
Copy Markdown
Member Author

The three red Labeler runs all failed before executing any workflow steps due to a GitHub Actions outage (Failed to resolve action download info. Error: Service Unavailable, ~15:44–15:49 UTC) — unrelated to the changes in this PR. All substantive checks (lint, affected tests, coverage, licenses) are green. I don't have permission to re-run workflows from this integration; a manual re-run (or any new PR event re-triggering the labeler) should clear them.


Generated by Claude Code

@kgryte kgryte changed the title chore: follow-up fixes for recent commits merged to develop chore: clean-up Aug 6, 2026
@kgryte
kgryte merged commit cfbd29a into develop Aug 6, 2026
17 of 20 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-08-06 branch August 6, 2026 16:59
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants