Repository navigation
test: migrate math/base/special/expit to ULP-based assertions - #13972
Merged
Merged
Conversation
Migrate the `math/base/special/expit` tests from relative tolerance (`EPS`-scaled) assertions to ULP-based assertions using `@stdlib/assert/is-almost-same-value`. The ULP bound was tightened to the measured minimum of `2` for both the JavaScript and native test files. Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014zrHEc6Qt61uPr8oo1zWcM
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/expitfrom relative tolerance (EPS-scaled) assertions to ULP-based assertions using@stdlib/assert/is-almost-same-value, matching the idiom used by previously converted double-precision packages (e.g.,ellipk,factorialln,falling-factorial,cphase).test/test.jsandtest/test.native.js, removing theEPS/absimports and thedelta/tolcomputations in favor oft.strictEqual( isAlmostSameValue( y, expected[ i ], 2 ), true, 'returns expected value' );.Final ULP constant:
2for every converted assertion, in both the JavaScript and native test files.The bound was tightened empirically rather than guessed. Starting from a high bound and lowering it, the measured maximum ULP distance over the full fixture set (5000 points in
test/fixtures/python/positive.jsonand 5000 points intest/fixtures/python/negative.json) is 2 ULP for both the JavaScript and the C implementation, so2is the minimum: atN = 1, each test file reports 34 failing assertions; atN = 2, all 10006 assertions pass in each file.The worst cases are:
x = -0.01604874543074996,y = 0.4959878997557333, expected0.4959878997557332x = 1.0563425188994806,y = 0.7419909757291605, expected0.7419909757291603Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
make install-node-addons NODE_ADDONS_PATTERN=expit) so thattest/test.native.jsgenuinely executed rather than being skipped.make lint-javascript-tests TESTS_FILTER=".*/math/base/special/expit/.*"is clean.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated, unattended run: it selected the package, studied the idiom used in previously merged conversions, applied the test edits, and measured the minimum passing ULP bound by running the suite.
@stdlib-js/reviewers
Generated by Claude Code