Repository navigation
test: migrate math/base/special/rad2degf to ULP-based assertions - #13970
Merged
Merged
Conversation
Ref: #11352 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ajs9WTBd63xXHqB6RJzGjL
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/rad2degffrom relative tolerance (EPS-scaled) assertions to ULP-based assertions using@stdlib/number/float32/base/assert/is-almost-same-value, matching the idiom already used by other single-precision packages (e.g.,acotdf,asecdf,atanf,hypotf).test/test.jsandtest/test.native.js, removing theEPS/absimports and thedelta/tolcomputations in favor oft.strictEqual( isAlmostSameValuef( r, e, 1 ), true, 'returns expected value' );.Final ULP constant:
1for every converted assertion, in both the JavaScript and native test files.The bound was tightened empirically rather than guessed. Starting from a high bound and lowering it, the measured maximum ULP distance over the full fixture set (2003 points in
test/fixtures/julia/data.json) plus the 32 canonical angle cases (16 positive and 16 negative) is 1 ULP for both the JavaScript and the C implementation.1is therefore the minimum: atN = 0the suite fails with 620 failing assertions (both files), and atN = 1all 2041 assertions pass.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
make install-node-addons NODE_ADDONS_PATTERN=rad2degf) so thattest/test.native.jsgenuinely executed rather than being skipped. Both files report 2041/2041 passing, and the suite was run twice at the final bound to confirm the result is deterministic (no FMA/architecture-dependent flakiness).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated, unattended run: it selected the package, studied the idiom used in previously merged conversions, applied the test edits, and measured the minimum passing ULP bound by running the suite.
@stdlib-js/reviewers
Generated by Claude Code