Skip to content

chore: fix C lint errors - #13964

Merged
kgryte merged 2 commits into
stdlib-js:developfrom
Ashutosh-1304:fix/c-lint-row-major-contiguous
Aug 6, 2026
Merged

kgryte merged 2 commits into
stdlib-js:developfrom
Ashutosh-1304:fix/c-lint-row-major-contiguous

Conversation

@Ashutosh-1304

Copy link
Copy Markdown
Contributor

Resolves #13963

Description

What is the purpose of this pull request?

This pull request:

  • adds const qualifiers to the shape and strides pointer parameters in stdlib_ndarray_is_row_major_contiguous since they are not modified within the function, resolving constParameterPointer lint warnings reported by cppcheck.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

@stdlib-js/reviewers

@Ashutosh-1304
Ashutosh-1304 requested a review from a team August 6, 2026 01:21
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 6, 2026
@stdlib-bot

stdlib-bot commented Aug 6, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
ndarray/base/assert/is-row-major-contiguous $\\color{green}137/137$
$\\color{green}+0.00\\%$
$\\color{green}5/5$
$\\color{green}+0.00\\%$
$\\color{green}1/1$
$\\color{green}+0.00\\%$
$\\color{green}137/137$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

Comment thread lib/node_modules/@stdlib/ndarray/base/assert/is-row-major-contiguous/src/main.c Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte
kgryte merged commit ed2034b into stdlib-js:develop Aug 6, 2026
11 checks passed
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. C Issue involves or relates to C. review: 4 and removed Needs Review A pull request which needs code review. labels Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Issue involves or relates to C. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix C lint errors

3 participants