Skip to content

style: resolve lint errors - #13911

Merged
kgryte merged 5 commits into
stdlib-js:developfrom
protestershankar:fix/eslint-lint-random-files-issues
Aug 8, 2026
Merged

kgryte merged 5 commits into
stdlib-js:developfrom
protestershankar:fix/eslint-lint-random-files-issues

Conversation

@protestershankar

Copy link
Copy Markdown
Contributor

Resolves N/A.

Description

What is the purpose of this pull request?

This pull request:

  • Fixes two ESLint violations flagged by the scheduled lint_random_files workflow: a stdlib/no-new-array violation in to_array.js (replaced the new Array() constructor with an array literal and push), and a stdlib/no-empty-lines-between-requires violation in test.ndarray.js (removed an empty line between two require statements).

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • None. These issues were identified via the scheduled lint_random_files CI workflow rather than a filed issue.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance.

I used Claude (Anthropic) to help identify the ESLint rule violations from the CI logs and to draft the corrected code, which I then reviewed and applied myself.


@stdlib-js/reviewers

@protestershankar
protestershankar requested a review from a team August 4, 2026 10:49
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Merge Conflicts Pull request which has merge conflicts. labels Aug 4, 2026
Comment thread lib/node_modules/@stdlib/_tools/modules/pkg-deps/lib/to_array.js Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/blas/base/dsymv/test/test.ndarray.js Outdated
Comment thread lib/node_modules/@stdlib/blas/base/dsymv/test/test.ndarray.js
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 3 and removed Needs Review A pull request which needs code review. Merge Conflicts Pull request which has merge conflicts. labels Aug 8, 2026
@stdlib-bot

stdlib-bot commented Aug 8, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

@kgryte kgryte changed the title fix: resolve eslint violations in to_array.js and test.ndarray.js style: resolve lint errors Aug 8, 2026
@kgryte
kgryte merged commit 35cf7c0 into stdlib-js:develop Aug 8, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants