Skip to content

docs: fix description - #13894

Merged
kgryte merged 4 commits into
developfrom
philipp/fix-commit-review-2026-08-03
Aug 4, 2026
Merged

kgryte merged 4 commits into
developfrom
philipp/fix-commit-review-2026-08-03

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes for commits merged to develop between 2026-08-02 13:20 (PT) (00f548b0) and 2026-08-03 03:38 (PT) (fa9cd2c7), based on an automated review of all 24 commits in that window.

This pull request:

blas/ext/base

  • Fix missing dtril/stril TS declarations and README ToC/link entries in blas/ext/base left out by 8a59dbb, which added the namespace registration in lib/index.js but not the corresponding docs/types/index.d.ts imports/interface entries or README updates (unlike dcopyWithin/gtril).

ml/base/loss/float64/squared-hinge-gradient

  • In squared-hinge-gradient/docs/repl.txt (line 28, from 36bce0b), the return value description read "Squared Hinge loss gradient." — capitalized "Hinge" inconsistent with sentence case elsewhere in the file and sibling packages (e.g., squared-error-gradient); lowercased to "Squared hinge loss gradient."

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation performed on the commit window:

  • Style-guide compliance audit (docs/style-guides) of all changed files, cross-checked against established sibling packages (e.g., dtriu/striu/gtriu, squared-error-gradient).
  • Bug scan of all introduced code (JS/C kernel pairs, documented example outputs, float64/float32 sibling consistency, native addon argument mappings, and the ml/base/sgd rename tree) — no runtime bugs found.
  • Deliberately excluded: anything requiring interpretation or judgment (e.g., a sec ULP-tolerance choice in 4f852f8 that differs from the secd migration in 21df521 but may be intentional), and anything whose fix would require changes outside the window's diff.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude Code as part of an automated daily review of commits merged to develop; a human maintainer will audit before marking ready for review.



Generated by Claude Code

claude added 2 commits August 3, 2026 19:53
…-hinge-gradient`

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018geBMhVSLDT8uWVJF44vHU
@stdlib-bot

stdlib-bot commented Aug 3, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
ml/base/loss/float64/squared-hinge-gradient $\\color{green}208/208$
$\\color{green}+0.00\\%$
$\\color{green}14/14$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}208/208$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of these changes is desired.

@kgryte kgryte closed this Aug 4, 2026
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-08-03 branch August 4, 2026 01:15
@kgryte
kgryte restored the philipp/fix-commit-review-2026-08-03 branch August 4, 2026 01:15
@kgryte kgryte reopened this Aug 4, 2026
@kgryte
kgryte marked this pull request as ready for review August 4, 2026 01:16
@kgryte
kgryte requested a review from a team August 4, 2026 01:16
@kgryte kgryte changed the title docs: follow-up fixes for recent commits merged to develop docs: fix description Aug 4, 2026
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 4, 2026
@kgryte
kgryte merged commit a4682f5 into develop Aug 4, 2026
35 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-08-03 branch August 4, 2026 02:02
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants