Repository navigation
test: migrate math/base/special/floorn to ULP-based testing - #13883
Merged
Merged
Conversation
Replace relative tolerance testing (EPS-based delta/tol comparison) with ULP difference testing via `@stdlib/assert/is-almost-same-value` for the subnormal rounding test case. Ref: #11352
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/floornfrom relative tolerance testing (a computedEPS-baseddelta/tolcomparison) to ULP difference testing using@stdlib/assert/is-almost-same-value, per the pattern described in [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.test/test.jsandtest/test.native.js, which contained an identical tolerance block in the "supports rounding very small numbers (including subnormals)" test case.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Verified locally:
node_modules/.bin/tape test/test.js→ 450/450 passing, run twice to confirm determinism at ULP=1.node_modules/.bin/eslint test/test.js test/test.native.js→ clean.test/test.native.jstest cases are skipped locally (no compiled native addon available in this environment), but the tolerance block was identical in source and was updated identically totest.js.package.jsonupdate was needed since@stdlib/assert/is-almost-same-valueis an internal stdlib package.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code (an AI coding assistant), converting the existing relative-tolerance test case to ULP-based assertions following the established pattern from previously merged conversions in this tracking issue (e.g.
math/base/special/roundn,math/base/special/csc). The minimum ULP bound was determined empirically by running the actual test suite.@stdlib-js/reviewers
Generated by Claude Code