Repository navigation
test: migrate math/base/special/secd to ULP-based testing - #13878
Merged
kgryte merged 1 commit intoAug 3, 2026
Merged
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
ujjwalv01
force-pushed
the
feat-math-base-special-secd-ulp
branch
2 times, most recently
from
August 3, 2026 06:33
1f98579 to
e0ff3e0
Compare
ujjwalv01
marked this pull request as ready for review
August 3, 2026 06:41
kgryte
reviewed
Aug 3, 2026
ujjwalv01
force-pushed
the
feat-math-base-special-secd-ulp
branch
from
August 3, 2026 08:24
e0ff3e0 to
685484d
Compare
Member
Author
|
I sincerely apologize for the oversight. That spacing changes were actually caused by my code editor's format-on-save feature (Prettier) triggering when I saved the file, which stripped the spaces inside the parentheses against the Thank you for pointing it out, I will be much more thorough with my self-reviews going forward to minimize review cycles! |
kgryte
reviewed
Aug 3, 2026
kgryte
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for the quick updates, @ujjwalv01!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/secdto use ULP-based testing viaisAlmostSameValue, replacing the old relative tolerance checks. The ULP bound has been tightly calibrated to the minimum required value.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
@stdlib-js/reviewers