Skip to content

test: migrate math/base/special/secd to ULP-based testing - #13878

Merged
kgryte merged 1 commit into
stdlib-js:developfrom
ujjwalv01:feat-math-base-special-secd-ulp
Aug 3, 2026
Merged

kgryte merged 1 commit into
stdlib-js:developfrom
ujjwalv01:feat-math-base-special-secd-ulp

Conversation

@ujjwalv01

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • Migrates the tests in math/base/special/secd to use ULP-based testing via isAlmostSameValue, replacing the old relative tolerance checks. The ULP bound has been tightly calibrated to the minimum required value.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. labels Aug 3, 2026
@stdlib-bot

stdlib-bot commented Aug 3, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/secd $\\color{green}186/186$
$\\color{green}+0.00\\%$
$\\color{green}5/5$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}186/186$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@ujjwalv01
ujjwalv01 force-pushed the feat-math-base-special-secd-ulp branch 2 times, most recently from 1f98579 to e0ff3e0 Compare August 3, 2026 06:33
@ujjwalv01
ujjwalv01 marked this pull request as ready for review August 3, 2026 06:41
@ujjwalv01
ujjwalv01 requested a review from a team August 3, 2026 06:41
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 3, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Tests Pull requests specifically adding tests. review: 5 and removed Needs Review A pull request which needs code review. labels Aug 3, 2026
Comment thread lib/node_modules/@stdlib/math/base/special/secd/test/test.native.js Outdated

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left initial comments.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. review: 2 and removed review: 5 labels Aug 3, 2026
@ujjwalv01
ujjwalv01 force-pushed the feat-math-base-special-secd-ulp branch from e0ff3e0 to 685484d Compare August 3, 2026 08:24
@ujjwalv01

Copy link
Copy Markdown
Member Author

I sincerely apologize for the oversight. That spacing changes were actually caused by my code editor's format-on-save feature (Prettier) triggering when I saved the file, which stripped the spaces inside the parentheses against the stdlib style guidelines. I definitely should have caught that during my self-review before pushing.

Thank you for pointing it out, I will be much more thorough with my self-reviews going forward to minimize review cycles!

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick updates, @ujjwalv01!

@kgryte
kgryte merged commit 21df521 into stdlib-js:develop Aug 3, 2026
11 checks passed
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. review: 2 Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants