Skip to content

fix: add check if xMin changed before emitting change event #13817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arjan-P wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: add check if xMin changed before emitting change event #13817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions lib/node_modules/@stdlib/plot/ctor/lib/props/x-min/set.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,21 +44,23 @@
function set( min ) {
/* eslint-disable no-invalid-this */

// TODO: add test to determine if evaluates to valid date?

Check warning on line 47 in lib/node_modules/@stdlib/plot/ctor/lib/props/x-min/set.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: add test to determine if evaluates...'
if (
!isNull( min ) &&
!isNumber( min ) // FIXME: finite number

Check warning on line 50 in lib/node_modules/@stdlib/plot/ctor/lib/props/x-min/set.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'fixme' comment: 'FIXME: finite number'

// TODO: Date
// TODO: Date

Check warning on line 52 in lib/node_modules/@stdlib/plot/ctor/lib/props/x-min/set.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: Date'
) {
throw new TypeError( format( 'invalid assignment. `%s` must be a finite number, Date, or null. Value: `%s`.', 'xMin', min ) );
}
debug( 'Current value: %s.', this._xMin );
if ( min !== this._xMin ) {
debug( 'Current value: %s.', this._xMin );

this._xMin = min;
debug( 'New value: %s.', this._xMin );
this._xMin = min;
debug( 'New value: %s.', this._xMin );

this.emit( 'change' );
this.emit( 'change' );
}
}


Expand Down