Skip to content

chore: fix JavaScript lint errors - #13776

Merged
kgryte merged 3 commits into
stdlib-js:developfrom
sharmakrishna1010:fix-js-lint-errors-13763
Jul 30, 2026
Merged

kgryte merged 3 commits into
stdlib-js:developfrom
sharmakrishna1010:fix-js-lint-errors-13763

Conversation

@sharmakrishna1010

Copy link
Copy Markdown
Contributor

Resolves #13763.

Description

What is the purpose of this pull request?

This pull request:

  • Fixes 3 reported JavaScript lint errors: stdlib/require-globals in utils/writable-property-names-in/lib/main.js, stdlib/no-multiple-empty-lines in _tools/lint/license-header-file-list/test/fixtures/start-location/file.js, and stdlib/no-new-array in assert/is-prototype-of/benchmark/benchmark.js. All fixes use single-line eslint-disable-line comments, matching the existing convention used elsewhere in the codebase for these same rules.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request?

No.

Checklist

  • Read, understood, and followed the [contributing guidelines][contributing].

AI Assistance

  • Yes

  • No

  • Code generation (e.g., when writing an implementation or fixing a bug)

  • Test/benchmark generation

  • Documentation (including examples)

  • Research and understanding

Disclosure

I used Claude (Anthropic's AI assistant) to help me understand the linked lint rules, locate the correct fix pattern by searching for existing usages of the same ESLint rules elsewhere in the codebase, and verify that my change to the test fixture wouldn't break its associated test. I wrote and ran all commands, made all file edits, and verified all test/lint results myself.


@stdlib-js/reviewers

@sharmakrishna1010
sharmakrishna1010 requested a review from a team July 30, 2026 09:23
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 30, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. labels Jul 30, 2026
@sharmakrishna1010
sharmakrishna1010 force-pushed the fix-js-lint-errors-13763 branch from b8a3dd8 to d6d6db1 Compare July 30, 2026 09:26
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@sharmakrishna1010
sharmakrishna1010 force-pushed the fix-js-lint-errors-13763 branch from d6d6db1 to 7c20aee Compare July 30, 2026 09:31
Comment thread lib/node_modules/@stdlib/utils/writable-property-names-in/lib/main.js Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 3 and removed Needs Review A pull request which needs code review. labels Jul 30, 2026
kgryte
kgryte previously approved these changes Jul 30, 2026

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after some clean-up.

Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@stdlib-bot

stdlib-bot commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
assert/is-prototype-of $\\color{green}127/127$
$\\color{green}+100.00\\%$
$\\color{green}11/11$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}127/127$
$\\color{green}+100.00\\%$
utils/writable-property-names-in $\\color{green}141/141$
$\\color{green}+100.00\\%$
$\\color{green}10/10$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}141/141$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte

kgryte commented Jul 30, 2026

Copy link
Copy Markdown
Member

As the CI failure is expected, I'll go ahead and merge.

@kgryte kgryte changed the title chore: fix JavaScript lint errors (issue #13763) chore: fix JavaScript lint errors Jul 30, 2026
@kgryte
kgryte merged commit 990d891 into stdlib-js:develop Jul 30, 2026
11 of 12 checks passed
@sharmakrishna1010
sharmakrishna1010 deleted the fix-js-lint-errors-13763 branch July 31, 2026 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. review: 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants