Repository navigation
chore: fix JavaScript lint errors - #13776
Merged
kgryte merged 3 commits intoJul 30, 2026
Merged
Conversation
Contributor
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
sharmakrishna1010
force-pushed
the
fix-js-lint-errors-13763
branch
from
July 30, 2026 09:26
b8a3dd8 to
d6d6db1
Compare
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
sharmakrishna1010
force-pushed
the
fix-js-lint-errors-13763
branch
from
July 30, 2026 09:31
d6d6db1 to
7c20aee
Compare
kgryte
reviewed
Jul 30, 2026
kgryte
reviewed
Jul 30, 2026
kgryte
reviewed
Jul 30, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Jul 30, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Jul 30, 2026
Member
|
As the CI failure is expected, I'll go ahead and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #13763.
Description
This pull request:
stdlib/require-globalsinutils/writable-property-names-in/lib/main.js,stdlib/no-multiple-empty-linesin_tools/lint/license-header-file-list/test/fixtures/start-location/file.js, andstdlib/no-new-arrayinassert/is-prototype-of/benchmark/benchmark.js. All fixes use single-lineeslint-disable-linecomments, matching the existing convention used elsewhere in the codebase for these same rules.Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
Yes
No
Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding
Disclosure
I used Claude (Anthropic's AI assistant) to help me understand the linked lint rules, locate the correct fix pattern by searching for existing usages of the same ESLint rules elsewhere in the codebase, and verify that my change to the test fixture wouldn't break its associated test. I wrote and ran all commands, made all file edits, and verified all test/lint results myself.
@stdlib-js/reviewers