Skip to content

test: migrate math/base/special/acoversinf to ULP-based testing #13774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 6 commits into from
Jul 31, 2026
Merged

test: migrate math/base/special/acoversinf to ULP-based testing #13774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
656ef01
test: migrate math/base/special/acoversinf to ULP-based testing
ujjwalv01 Jul 29, 2026
bf19ebe
test: decrease ULP to 233 to verify failure
ujjwalv01 Jul 30, 2026
0509aa2
test: migrate math/base/special/acoversinf to ULP-based testing
ujjwalv01 Jul 30, 2026
6f33b17
Discard changes to lib/node_modules/@stdlib/ndarray/base/diagonal/doc…
kgryte Jul 30, 2026
aca11b3
test: decrease ULP to 2 for small positive numbers block
ujjwalv01 Jul 31, 2026
02a10ec
test: decrease ULP to 1 for small positive numbers block
ujjwalv01 Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 5 additions & 21 deletions lib/node_modules/@stdlib/math/base/special/acoversinf/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@

var tape = require( 'tape' );
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
var isAlmostSameValuef = require( '@stdlib/number/float32/base/assert/is-almost-same-value' );
var randu = require( '@stdlib/random/base/randu' );
var absf = require( '@stdlib/math/base/special/absf' );
var EPS = require( '@stdlib/constants/float32/eps' );
var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );
var acoversinf = require( './../lib' );
Expand All @@ -45,8 +45,6 @@ tape( 'main export is a function', function test( t ) {

tape( 'the function computes the inverse coversed sine', function test( t ) {
var expected;
var delta;
var tol;
var x;
var y;
var i;
Expand All @@ -57,22 +55,14 @@ tape( 'the function computes the inverse coversed sine', function test( t ) {

for ( i = 0; i < x.length; i++ ) {
e = float64ToFloat32( expected[ i ] );
y = acoversinf( x[i] );
if ( y === e ) {
t.strictEqual( y, e, 'x: '+x[i]+'. E: '+e );
} else {
delta = absf( y - e );
tol = 230.0 * EPS * absf( e );
t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+e+'. tol: '+tol+'. Δ: '+delta+'.' );
}
y = acoversinf( x[ i ] );
t.strictEqual( isAlmostSameValuef( y, e, 234 ), true, 'returns expected value' );
}
t.end();
});

tape( 'the function computes the inverse coversed sine (small positive numbers)', function test( t ) {
var expected;
var delta;
var tol;
var x;
var y;
var i;
Expand All @@ -83,14 +73,8 @@ tape( 'the function computes the inverse coversed sine (small positive numbers)'

for ( i = 0; i < x.length; i++ ) {
e = float64ToFloat32( expected[ i ] );
y = acoversinf( x[i] );
if ( y === e ) {
t.strictEqual( y, e, 'x: '+x[i]+'. E: '+e );
} else {
delta = absf( y - e );
tol = EPS * absf( e );
t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+e+'. tol: '+tol+'. Δ: '+delta+'.' );
}
y = acoversinf( x[ i ] );
t.strictEqual( isAlmostSameValuef( y, e, 1 ), true, 'returns expected value' );
}
t.end();
});
Expand Down
26 changes: 5 additions & 21 deletions lib/node_modules/@stdlib/math/base/special/acoversinf/test/test.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
var resolve = require( 'path' ).resolve;
var tape = require( 'tape' );
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
var isAlmostSameValuef = require( '@stdlib/number/float32/base/assert/is-almost-same-value' );
var randu = require( '@stdlib/random/base/randu' );
var absf = require( '@stdlib/math/base/special/absf' );
var EPS = require( '@stdlib/constants/float32/eps' );
var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );
var tryRequire = require( '@stdlib/utils/try-require' );
Expand Down Expand Up @@ -54,8 +54,6 @@ tape( 'main export is a function', opts, function test( t ) {

tape( 'the function computes the inverse coversed sine', opts, function test( t ) {
var expected;
var delta;
var tol;
var x;
var y;
var i;
Expand All @@ -66,22 +64,14 @@ tape( 'the function computes the inverse coversed sine', opts, function test( t

for ( i = 0; i < x.length; i++ ) {
e = float64ToFloat32( expected[ i ] );
y = acoversinf( x[i] );
if ( y === e ) {
t.strictEqual( y, e, 'x: '+x[i]+'. E: '+e );
} else {
delta = absf( y - e );
tol = 230.0 * EPS * absf( e );
t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+e+'. tol: '+tol+'. Δ: '+delta+'.' );
}
y = acoversinf( x[ i ] );
t.strictEqual( isAlmostSameValuef( y, e, 234 ), true, 'returns expected value' );
}
t.end();
});

tape( 'the function computes the inverse coversed sine (small positive numbers)', opts, function test( t ) {
var expected;
var delta;
var tol;
var x;
var y;
var i;
Expand All @@ -92,14 +82,8 @@ tape( 'the function computes the inverse coversed sine (small positive numbers)'

for ( i = 0; i < x.length; i++ ) {
e = float64ToFloat32( expected[ i ] );
y = acoversinf( x[i] );
if ( y === e ) {
t.strictEqual( y, e, 'x: '+x[i]+'. E: '+e );
} else {
delta = absf( y - e );
tol = EPS * absf( e );
t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+e+'. tol: '+tol+'. Δ: '+delta+'.' );
}
y = acoversinf( x[ i ] );
t.strictEqual( isAlmostSameValuef( y, e, 1 ), true, 'returns expected value' );
}
t.end();
});
Expand Down