feat: add `stats/incr/nanmrmse` by Arjan-P · Pull Request #13747 · stdlib-js/stdlib

Arjan-P · 2026-07-29T10:21:25Z

Resolves #5606

Description

What is the purpose of this pull request?

This pull request:

Adds stats/incr/nanmrmse which calculates moving product, ignoring NaN values.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: passed - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown_pkg_readmes status: na - task: lint_markdown_docs status: na - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

stdlib-bot · 2026-07-29T10:25:03Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/incr/nanmrmse	$\\color{green}149/149$ $\\color{green}+0.00\\%$	$\\color{green}7/7$ $\\color{green}+0.00\\%$	$\\color{green}2/2$ $\\color{green}+0.00\\%$	$\\color{green}149/149$ $\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

Planeshifter · 2026-07-29T12:09:59Z

⚠️ Issue Reference Review

An automated check found potentially unrelated issue/PR references in this PR:

Reference	Assessment	Reasoning
#5604	suspicious	PR adds `stats/incr/nanmrmse`, but issue #5604 is the RFC for a different, unrelated package: `stats/incr/nanmprod`.

Why this matters: GitHub automatically closes issues referenced with
closing keywords (Resolves, Closes, Fixes) when the PR is merged. Incorrect
references can accidentally close unrelated issues.

What to do:

If the reference is correct, no action needed. This check may produce
false positives.
If the reference is incorrect, please update your PR description.

This assessment was generated by an AI model and is informational only.

Generated by Claude Code

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

- Remove non-conventional single-argument special-casing in main.js; use the standard combined guard and rename inner var to 'mrmse' - Replace single-argument NaN examples with two-argument NaN pairs in JSDoc, repl.txt, index.d.ts, and README - Rewrite test suite to correct NaN-ignoring expectations and cover (NaN,y), (x,NaN), (NaN,NaN), and only-NaN cases - Inject NaN values in examples/index.js and README examples with guarded printing - Fix Notes wording in README - Remove non-standard 'ignore' keyword from package.json

Planeshifter

Let's get it in!

stdlib-bot · 2026-08-04T06:42:44Z

PR Commit Message

feat: add `stats/incr/nanmrmse`

PR-URL: https://github.com/stdlib-js/stdlib/pull/13747
Ref: https://github.com/stdlib-js/stdlib/issues/5606
Ref: https://github.com/stdlib-js/stdlib/issues/5966

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

⚠️ Action Required: This PR references tracking issues. Please update the PR description to replace any "Closes", "Fixes", or "Resolves" keywords with "Ref" when referencing these issues.

Arjan-P added 7 commits July 29, 2026 15:38

Arjan-P requested a review from a team July 29, 2026 10:21

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jul 29, 2026

Planeshifter mentioned this pull request Aug 4, 2026

Land stats/incr/nan* PRs by Arjan-P stdlib-js/metr-issue-tracker#1108

Closed

Planeshifter reviewed Aug 4, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/stats/incr/nanmrmse/README.md Outdated

Planeshifter reviewed Aug 4, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/stats/incr/nanmrmse/README.md Outdated

chore: leave related packages empty

d49a8a5

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Planeshifter reviewed Aug 4, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/stats/incr/nanmrmse/README.md Outdated

chore: remove empty line

1654d98

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Planeshifter reviewed Aug 4, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/stats/incr/nanmrmse/README.md

Planeshifter added 2 commits August 4, 2026 01:28

chore: add empty line

14f1c1f

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Planeshifter approved these changes Aug 4, 2026

View reviewed changes

Planeshifter added the Ready To Merge label Aug 4, 2026

stdlib-bot removed the Needs Review A pull request which needs code review. label Aug 4, 2026

Planeshifter merged commit 87644fb into stdlib-js:develop Aug 4, 2026
31 checks passed

stdlib-bot removed the Ready To Merge label Aug 4, 2026

Arjan-P deleted the add-nanmrmse branch August 4, 2026 13:01

Navigation Menu

Repository navigation

feat: add `stats/incr/nanmrmse` - #13747

feat: add `stats/incr/nanmrmse`#13747
Planeshifter merged 11 commits into
stdlib-js:developfrom
Arjan-P:add-nanmrmse

Arjan-P commented Jul 29, 2026 •

edited

Loading

Uh oh!

stdlib-bot commented Jul 29, 2026 •

edited

Loading

Uh oh!

Planeshifter commented Jul 29, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Planeshifter left a comment

Uh oh!

stdlib-bot commented Aug 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Arjan-P commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

stdlib-bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Planeshifter commented Jul 29, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Aug 4, 2026

PR Commit Message

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Arjan-P commented Jul 29, 2026 •

edited

Loading

stdlib-bot commented Jul 29, 2026 •

edited

Loading