Repository navigation
test: migrate math/base/special/spencef to ULP-based testing - #13726
Merged
Merged
Conversation
ujjwalv01
force-pushed
the
test-spencef-ulp
branch
from
July 28, 2026 18:37
76620a9 to
6746b5a
Compare
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
ujjwalv01
force-pushed
the
test-spencef-ulp
branch
from
July 28, 2026 18:42
6746b5a to
64ae9a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/spencef(test.jsandtest.native.js) from relative tolerance testing to ULP difference testing using@stdlib/number/float32/base/assert/is-almost-same-value.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Implementation Note on float32 ULP Tolerances:
Since
spencefoperates in single-precision (float32), this PR replacesabsfandEPSwith@stdlib/number/float32/base/assert/is-almost-same-valueto assert bit-level differences.When evaluating the 4 test loops against their corresponding Python test fixtures, the minimum required float32 ULP tolerances were determined as follows per Instruction "4" of RFC #11352:
These exact minimal thresholds achieve a 100% pass rate (2,105 / 2,105 passing) across all test suites, establishing the exact strict mathematical bounds required for precision validation. Lowering any of these bounds by even
1ULP immediately triggers failures on the Python fixtures.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
@stdlib-js/reviewers