Skip to content

test: migrate math/base/special/cosd to ULP-based testing - #13704

Merged
kgryte merged 1 commit into
developfrom
philipp/ulp-cosd
Jul 27, 2026
Merged

kgryte merged 1 commit into
developfrom
philipp/ulp-cosd

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • Migrates the unit tests for math/base/special/cosd (test.js and test.native.js) from relative tolerance testing to ULP difference testing using @stdlib/assert/is-almost-same-value.
  • Final ULP bound: 1 for both the negative-values and positive-values fixture loops (in both test.js and test.native.js). This is the measured minimum — a bound of 0 fails on multiple fixture entries; 1 passes the full fixture set deterministically across repeated runs.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code, which searched for an unconverted math/base/special package, studied prior-art merged ULP-migration PRs (e.g. sind, atanh, erfinv) to mirror the established idiom, and empirically determined the minimum passing ULP bound by running the test suite.


@stdlib-js/reviewers


Generated by Claude Code

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Good First PR A pull request resolving a Good First Issue. labels Jul 27, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/cosd $\\color{green}193/193$
$\\color{green}+100.00\\%$
$\\color{green}16/16$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}193/193$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Tests Pull requests specifically adding tests. review: 5 labels Jul 27, 2026
@kgryte
kgryte marked this pull request as ready for review July 27, 2026 22:05
@kgryte
kgryte requested a review from a team July 27, 2026 22:05
@kgryte
kgryte merged commit 6df71ed into develop Jul 27, 2026
103 checks passed
@kgryte
kgryte deleted the philipp/ulp-cosd branch July 27, 2026 22:05
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. review: 5 Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants