Repository navigation
test: migrate math/base/special/cosd to ULP-based testing - #13704
Merged
Merged
Conversation
Resolves a part of #11352.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
July 27, 2026 22:05
kgryte
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/cosd(test.jsandtest.native.js) from relative tolerance testing to ULP difference testing using@stdlib/assert/is-almost-same-value.1for both the negative-values and positive-values fixture loops (in bothtest.jsandtest.native.js). This is the measured minimum — a bound of0fails on multiple fixture entries;1passes the full fixture set deterministically across repeated runs.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, which searched for an unconverted
math/base/specialpackage, studied prior-art merged ULP-migration PRs (e.g.sind,atanh,erfinv) to mirror the established idiom, and empirically determined the minimum passing ULP bound by running the test suite.@stdlib-js/reviewers
Generated by Claude Code