Repository navigation
feat: add lapack/base/dptts2 - #13703
Open
iampratik13 wants to merge 4 commits into
Open
iampratik13 wants to merge 4 commits into
iampratik13 wants to merge 4 commits into
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: passed
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: na
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
iampratik13
marked this pull request as ready for review
July 28, 2026 19:45
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: passed
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
Comment on lines
+31
to
+57
| * @param {NonNegativeInteger} N - order of the tridiagonal matrix `A` | ||
| * @param {NonNegativeInteger} nrhs - number of right-hand sides (i.e., the number of columns of the matrix `B`) | ||
| * @param {Float64Array} D - the `N` diagonal elements of the diagonal matrix `D` from the factorization of `A` | ||
| * @param {integer} sd - stride length for `D` | ||
| * @param {NonNegativeInteger} od - starting index for `D` | ||
| * @param {Float64Array} E - the `N-1` subdiagonal elements of the unit bidiagonal factor `L` from the factorization of `A` | ||
| * @param {integer} se - stride length for `E` | ||
| * @param {NonNegativeInteger} oe - starting index for `E` | ||
| * @param {Float64Array} B - input matrix (overwritten by the solution matrix `X`) | ||
| * @param {integer} sb1 - stride of the first dimension of `B` | ||
| * @param {integer} sb2 - stride of the second dimension of `B` | ||
| * @param {NonNegativeInteger} ob - starting index for `B` | ||
| * @returns {Float64Array} solution matrix `X` (stored in `B`) | ||
| * | ||
| * @example | ||
| * var Float64Array = require( '@stdlib/array/float64' ); | ||
| * | ||
| * var D = new Float64Array( [ 4.0, 4.75, 5.157894736842105 ] ); | ||
| * var E = new Float64Array( [ 0.25, 0.42105263157894735 ] ); | ||
| * var B = new Float64Array( [ 1.0, 2.0, 3.0 ] ); | ||
| * | ||
| * dptts2( 3, 1, D, 1, 0, E, 1, 0, B, 1, 3, 0 ); | ||
| * // B => <Float64Array>[ ~0.2041, ~0.1837, ~0.4388 ] | ||
| */ | ||
| function dptts2( N, nrhs, D, sd, od, E, se, oe, B, sb1, sb2, ob ) { // eslint-disable-line max-params | ||
| return base( N, nrhs, D, sd, od, E, se, oe, B, sb1, sb2, ob ); | ||
| } |
Member
There was a problem hiding this comment.
Rename these to match base.js — strideD, offsetD, strideE, offsetE, strideB1, strideB2, offsetB — instead of the abbreviated forms. Every other lapack/base package (dpttrf, dgttrf, dlacpy, etc.) uses the full names throughout ndarray.js, docs, and README; this file should be consistent. Update docs/types/index.d.ts, docs/repl.txt, and README.md too.
Generated by Claude Code
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Resolves none.
Description
This pull request:
lapack/base/dptts2Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers