Skip to content

feat: add number/uint64/base/xor - #13701

Merged
kgryte merged 4 commits into
stdlib-js:developfrom
impawstarlight:feature/uint64-base-xor
Jul 27, 2026
Merged

feat: add number/uint64/base/xor#13701
kgryte merged 4 commits into
stdlib-js:developfrom
impawstarlight:feature/uint64-base-xor

Conversation

@impawstarlight

@impawstarlight impawstarlight commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Adds a package for computing the bitwise XOR of two 64-bit unsigned integers.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

N/A.

@stdlib-js/reviewers

@impawstarlight
feat: add number/uint64/base/xor
3610df0 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@impawstarlight
impawstarlight requested a review from a team July 27, 2026 16:06
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 27, 2026
@stdlib-bot

stdlib-bot commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
number/uint64/base/xor $\\color{green}231/231$
$\\color{green}+0.00\\%$ 		$\\color{green}7/7$
$\\color{green}+0.00\\%$ 		$\\color{green}3/3$
$\\color{green}+0.00\\%$ 		$\\color{green}231/231$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed Needs Review A pull request which needs code review. labels Jul 27, 2026
kgryte
kgryte reviewed Jul 27, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/number/uint64/base/xor/benchmark/benchmark.js Outdated
kgryte
kgryte reviewed Jul 27, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/number/uint64/base/xor/lib/main.js Outdated
@kgryte
Apply suggestions from code review
91bc78a 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jul 27, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/number/uint64/base/xor/docs/types/index.d.ts Outdated
@kgryte
Apply suggestions from code review
ce7d45d 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Jul 27, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/number/uint64/base/xor/package.json Outdated
@kgryte
Apply suggestions from code review
11a2a5b 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Jul 27, 2026
View reviewed changes

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@impawstarlight Same comment regarding a future C API. Something for us to remember to do, even if it is not the highest priority atm.

@kgryte
kgryte merged commit 31c730e into stdlib-js:develop Jul 27, 2026
13 checks passed
@impawstarlight
impawstarlight deleted the feature/uint64-base-xor branch July 28, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@impawstarlight @stdlib-bot @kgryte