Skip to content

feat: add blas/ext/base/dwxmy - #13688

Merged
kgryte merged 2 commits into
stdlib-js:developfrom
anandkaranubc:feat/dwxmy
Jul 28, 2026
Merged

feat: add blas/ext/base/dwxmy#13688
kgryte merged 2 commits into
stdlib-js:developfrom
anandkaranubc:feat/dwxmy

Conversation

@anandkaranubc

@anandkaranubc anandkaranubc commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Resolves stdlib-js/metr-issue-tracker#1082

Description

What is the purpose of this pull request?

This pull request:

  • adds blas/ext/base/dwxmy

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Used Cursor+VS Code code-generation tools to help assist with the feature.

@stdlib-js/reviewers

@anandkaranubc
feat: add blas/ext/base/dwxmy
cd13567 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
anandkaranubc requested a review from a team July 27, 2026 07:29
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. labels Jul 27, 2026
@anandkaranubc anandkaranubc added Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. C Issue involves or relates to C. METR Pull request associated with the METR project. labels Jul 27, 2026
anandkaranubc
anandkaranubc commented Jul 27, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/dwxmy/README.md Outdated

# dwxmy

> Perform the element-wise operation `w = x * y` for double-precision floating-point strided arrays.

@anandkaranubc anandkaranubc Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally taking a step toward less verbose descriptions :)

@kgryte kgryte Jul 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, although, I am not sure we want to go that direction given your existing precedent for gwxmy and the rest of the *wx*y family of packages. Meaning, if we are going to go concise, it should be consistent across them all.

Given that the more verbose description is already in use for gwxmy, I am thinking we should also be more verbose here.

@anandkaranubc anandkaranubc Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, on it!

@kgryte kgryte Jul 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anandkaranubc Also see #13688 (comment). Your call. I am fine either way.

@stdlib-bot

stdlib-bot commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/dwxmy $\\color{green}426/426$
$\\color{green}+0.00\\%$ 		$\\color{green}28/28$
$\\color{green}+0.00\\%$ 		$\\color{green}4/4$
$\\color{green}+0.00\\%$ 		$\\color{green}426/426$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jul 28, 2026
kgryte
kgryte reviewed Jul 28, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/dwxmy/docs/types/index.d.ts Outdated
*/
interface Routine {
/**
* Performs the element-wise operation `w = x * y` for double-precision floating-point strided arrays.

@kgryte kgryte Jul 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anandkaranubc This is a different description than what you used in gwxmy. Shouldn't we be consistent here?

@anandkaranubc anandkaranubc Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, @kgryte. This description, however, was getting way too verbose. If this is fine, I will go ahead and change the gwxmy description too.

@anandkaranubc anandkaranubc Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, we would have:

Multiplies elements of a double-precision floating-point strided array xby the corresponding elements of a double-precision floating-point strided arrayyand assigns the results to elements in a double-precision floating-point strided arrayw using alternative indexing semantics.

@kgryte kgryte Jul 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you. It isn't just gwxmy, but also gwxpy and gwxsy would need to be migrated.

kgryte
kgryte reviewed Jul 28, 2026
View reviewed changes

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main comment concerns the descriptions.

@anandkaranubc
docs: update descriptions in blas/ext/base/dwxmy for consistency
2e6b01c 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
kgryte
kgryte approved these changes Jul 28, 2026
View reviewed changes

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte
kgryte merged commit 04ecde1 into stdlib-js:develop Jul 28, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. METR Pull request associated with the METR project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add blas/ext/base/dwxmy

3 participants

@anandkaranubc @stdlib-bot @kgryte