Repository navigation
test: migrate math/base/special/acotf to ULP-based testing - #13659
Merged
Merged
Conversation
Replaces the relative-tolerance (EPS/abs/tol) assertions in test/test.js and test/test.native.js with ULP-difference assertions via `@stdlib/number/float32/base/assert/is-almost-same-value`, using the minimum measured ULP bound for each fixture set. Ref: #11352
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/acotftest cases from relative-tolerance-based assertions (EPS/abs/tolidiom) to ULP-based assertions using@stdlib/number/float32/base/assert/is-almost-same-valuein bothtest/test.jsandtest/test.native.js.3formedium_positive/medium_negative,2forlarge_positive/large_negative/larger_positive/larger_negative, and1forhuge_positive/huge_negative. Each bound is the smallest integer for which the full fixture set passes (verified by lowering toN-1and confirming at least one failure in every group).test.jsand the native binding (test.native.js, built locally vianode-gyp rebuild) to confirm deterministic results (no FMA/arch flakiness).Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
Final ULP constants:
3(medium),2(large/larger),1(huge).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, running as an automated scheduled task: it discovered the candidate package, studied prior art from already-converted packages, performed the conversion, measured the tightest ULP bounds agentically, and verified the result.
@stdlib-js/reviewers
Generated by Claude Code