Skip to content

refactor(ml/incr)!: convert loss function names to kebab-case - #13641

Open
Ashutosh-1304 wants to merge 6 commits into
stdlib-js:developfrom
Ashutosh-1304:refactor/ml-incr-loss-kebab-case
Open

Ashutosh-1304 wants to merge 6 commits into
stdlib-js:developfrom
Ashutosh-1304:refactor/ml-incr-loss-kebab-case

Conversation

@Ashutosh-1304

Copy link
Copy Markdown
Contributor

Resolves #13359

Description

This pull request refactors loss function option names in @stdlib/ml/incr/binary-classification and @stdlib/ml/incr/sgd-regression from camelCase to kebab-case to conform with stdlib naming conventions:

  • @stdlib/ml/incr/binary-classification:
    • modifiedHuber $\rightarrow$ modified-huber
    • squaredHinge $\rightarrow$ squared-hinge
  • @stdlib/ml/incr/sgd-regression:
    • epsilonInsensitive $\rightarrow$ epsilon-insensitive
    • squaredError $\rightarrow$ squared-error

This includes updates to core module options, default configurations, TypeScript definitions, validation checks, tests, REPL files, and package documentation.

Related Issues

This pull request has the following related issues:

Questions

No.

Other

No.

Checklist

  • Read, understood, and followed the [contributing guidelines][contributing].

AI Assistance

  • Yes
  • No

@stdlib-js/reviewers

@Ashutosh-1304
Ashutosh-1304 requested a review from a team July 24, 2026 11:31
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Jul 24, 2026
@Ashutosh-1304
Ashutosh-1304 force-pushed the refactor/ml-incr-loss-kebab-case branch from 87e7622 to ae3b8f3 Compare July 24, 2026 11:36
@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Jul 24, 2026
@0PrashantYadav0

Copy link
Copy Markdown
Member

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Aug 6, 2026
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Aug 6, 2026
@stdlib-bot

stdlib-bot commented Aug 6, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
ml/incr $\\color{red}2599/4386$
$\\color{green}+0.00\\%$
$\\color{green}40/40$
$\\color{green}+0.00\\%$
$\\color{red}0/58$
$\\color{green}+0.00\\%$
$\\color{red}2599/4386$
$\\color{green}+0.00\\%$
ml/incr/binary-classification $\\color{red}719/1023$
$\\color{green}+0.00\\%$
$\\color{red}31/32$
$\\color{green}+0.00\\%$
$\\color{red}2/22$
$\\color{green}+0.00\\%$
$\\color{red}719/1023$
$\\color{green}+0.00\\%$
ml/incr/sgd-regression $\\color{green}917/917$
$\\color{green}+0.00\\%$
$\\color{green}103/103$
$\\color{green}+0.00\\%$
$\\color{green}18/18$
$\\color{green}+0.00\\%$
$\\color{green}917/917$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

@nakul-krishnakumar nakul-krishnakumar left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thank you @Ashutosh-1304 for working on this issue!

cc: @kgryte

@nakul-krishnakumar nakul-krishnakumar changed the title refactor(ml/incr): convert loss function names to kebab-case refactor(ml/incr)!: convert loss function names to kebab-case Aug 7, 2026
@Ashutosh-1304

Copy link
Copy Markdown
Contributor Author

@kgryte kindly review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: usage of camelcase for loss functions in ml/incr/*

4 participants