Skip to content

test: migrate math/base/special/sind to ULP-based testing - #13583

Merged
kgryte merged 1 commit into
stdlib-js:developfrom
ujjwalv01:refactor-ulp-sind
Jul 20, 2026
Merged

kgryte merged 1 commit into
stdlib-js:developfrom
ujjwalv01:refactor-ulp-sind

Conversation

@ujjwalv01

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • Migrates math/base/special/sind tests from relative tolerance (EPS) to ULP-based testing using isAlmostSameValue.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

@ujjwalv01
ujjwalv01 requested a review from a team July 20, 2026 09:25
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Jul 20, 2026
@ujjwalv01
ujjwalv01 force-pushed the refactor-ulp-sind branch from 8ba64e5 to 99fabf6 Compare July 20, 2026 09:30
@ujjwalv01
ujjwalv01 force-pushed the refactor-ulp-sind branch from 99fabf6 to d5eb7de Compare July 20, 2026 09:36
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/sind $\\color{green}202/202$
$\\color{green}+100.00\\%$
$\\color{green}20/20$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}202/202$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte changed the title test: migrate \math/base/special/sind\ to ULP-based testing test: migrate math/base/special/sind to ULP-based testing Jul 20, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 and removed Needs Review A pull request which needs code review. labels Jul 20, 2026
@kgryte

kgryte commented Jul 20, 2026

Copy link
Copy Markdown
Member

LGTM

@kgryte kgryte added the Tests Pull requests specifically adding tests. label Jul 20, 2026
@kgryte
kgryte merged commit c61ccdd into stdlib-js:develop Jul 20, 2026
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. review: 5 Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants