Skip to content

feat: add blas/ext/base/gtriu - #13580

Merged
kgryte merged 14 commits into
stdlib-js:developfrom
MeKaustubh07:blas/ext/base/gtriu
Jul 26, 2026
Merged

kgryte merged 14 commits into
stdlib-js:developfrom
MeKaustubh07:blas/ext/base/gtriu

Conversation

@MeKaustubh07

Copy link
Copy Markdown
Member

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown_pkg_readmes status: passed
  • task: lint_markdown_docs status: na
  • task: lint_markdown status: na
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed ---

Resolves #{{TODO: add issue number}}.

Description

What is the purpose of this pull request?

This pull request:

  • feat: add blas/ext/base/gtriu

Related Issues

Resolves #13550

This pull request has the following related issues:

  • #{{TODO: add related issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@MeKaustubh07
MeKaustubh07 requested a review from a team July 20, 2026 06:55
@MeKaustubh07
MeKaustubh07 marked this pull request as draft July 20, 2026 06:56
@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Jul 20, 2026
@stdlib-bot

stdlib-bot commented Jul 20, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/gtriu $\\color{green}439/439$
$\\color{green}+0.00\\%$
$\\color{green}37/37$
$\\color{green}+0.00\\%$
$\\color{green}4/4$
$\\color{green}+0.00\\%$
$\\color{green}439/439$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@MeKaustubh07
MeKaustubh07 marked this pull request as ready for review July 23, 2026 06:13
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 23, 2026
@kgryte kgryte added Feature Issue or pull request for adding a new feature. GSoC Google Summer of Code. gsoc: 2026 Google Summer of Code (2026). and removed Needs Review A pull request which needs code review. labels Jul 26, 2026
Comment thread lib/node_modules/@stdlib/blas/ext/base/gtriu/benchmark/benchmark.ndarray.js Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/blas/ext/base/gtriu/lib/base.js Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/blas/ext/base/gtriu/lib/main.js Outdated
Comment thread lib/node_modules/@stdlib/blas/ext/base/gtriu/lib/main.js
Comment thread lib/node_modules/@stdlib/blas/ext/base/gtriu/lib/main.js
Comment thread lib/node_modules/@stdlib/blas/ext/base/gtriu/lib/main.js Outdated
Comment thread lib/node_modules/@stdlib/blas/ext/base/gtriu/lib/main.js Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/blas/ext/base/gtriu/lib/main.js Outdated
kgryte added 3 commits July 26, 2026 01:47
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/blas/ext/base/gtriu/README.md Outdated
Comment thread lib/node_modules/@stdlib/blas/ext/base/gtriu/README.md Outdated
kgryte added 2 commits July 26, 2026 02:00
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/blas/ext/base/gtriu/test/test.ndarray.js Outdated
Comment thread lib/node_modules/@stdlib/blas/ext/base/gtriu/test/test.ndarray.js Outdated
kgryte added 4 commits July 26, 2026 02:09
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte previously approved these changes Jul 26, 2026

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeKaustubh07 You have done a number of these blas/ext/base/g* packages. I shouldn't have to be cleaning up your tests at this point. Don't take shortcuts. The code coverage report should have been enough of an indication that your tests were incomplete.

Comment thread lib/node_modules/@stdlib/blas/ext/base/gtriu/test/test.ndarray.js Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte

kgryte commented Jul 26, 2026 •

Copy link
Copy Markdown
Member

@MeKaustubh07 Now that we have added gtriu, you can add blas/ext/base/gtril (copying the lower triangular part and where k semantics flip with elements above the specified diagonal ignored).

You can also go ahead and add

blas/ext/base/dtriu
blas/ext/base/striu
blas/ext/base/ctriu
blas/ext/base/ztriu

@kgryte
kgryte merged commit 651f410 into stdlib-js:develop Jul 26, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. GSoC Google Summer of Code. gsoc: 2026 Google Summer of Code (2026). review: 2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add blas/ext/base/gtriu

3 participants