Skip to content

build: increase update equation step timeout - #13578

Merged
kgryte merged 2 commits into
stdlib-js:developfrom
officiallyanee:fix/markdown-equations-timeout
Jul 20, 2026
Merged

kgryte merged 2 commits into
stdlib-js:developfrom
officiallyanee:fix/markdown-equations-timeout

Conversation

@officiallyanee

@officiallyanee officiallyanee commented Jul 20, 2026 •

Copy link
Copy Markdown
Member

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown_pkg_readmes status: na
  • task: lint_markdown_docs status: na
  • task: lint_markdown status: na
  • task: lint_package_json status: na
  • task: lint_repl_help status: na
  • task: lint_javascript_src status: na
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: na
  • task: lint_javascript_tests status: na
  • task: lint_javascript_benchmarks status: na
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: na
  • task: lint_license_headers status: passed ---

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • increases update equation step timeout to 20 minutes from 15 minutes following of the failing workflow due to timeout: https://github.com/stdlib-js/stdlib/actions/runs/29713582835/job/88261872208
    It ran two make commands over 124 files and failed while processing the 120th file in second make command run.
    So doing some math ( which may be a little off since i didn't take into account one make command can take more time on average than the other ) 124x2=248 processing out of which it failed at 244th, so (15x60/244) = ~3.7s processing per file (twice). It needed approximately 15 secs more but as a safeguard bumping it up by 5mins.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@officiallyanee
officiallyanee requested a review from a team July 20, 2026 05:56
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 20, 2026
Comment thread .github/workflows/markdown_equations.yml Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for monitoring, @officiallyanee!

@kgryte kgryte changed the title build: increase update equation step timeout to 20 minutes build: increase update equation step timeout Jul 20, 2026
@kgryte
kgryte merged commit 944dc8a into stdlib-js:develop Jul 20, 2026
9 checks passed
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jul 20, 2026
@kgryte

kgryte commented Jul 20, 2026

Copy link
Copy Markdown
Member

Just kicked off a manual run of the workflow. Fingers crossed. 🤞

@officiallyanee

Copy link
Copy Markdown
Member Author

#13579 it worked! 🎉

@kgryte

kgryte commented Jul 20, 2026

Copy link
Copy Markdown
Member

Great! Let's hope I don't mess up the merge this time. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants