Skip to content

chore: clean-up - #13487

Merged
kgryte merged 2 commits into
developfrom
philipp/fix-commit-review-2026-07-15
Jul 16, 2026
Merged

kgryte merged 2 commits into
developfrom
philipp/fix-commit-review-2026-07-15

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • Follow-up fixes for commits merged to develop between 2026-07-14 15:02 UTC-7 and 2026-07-15 01:56 UTC-7 (23 commits, dc0fcd8..815a3b8).

Fixes, by package:

  • stats/incr/nanmmaxabs: package.json description was missing the trailing , ignoring NaN values clause every other nanm* accumulator has; appended it (5308a5e).
  • lapack/base/dlarf1f: drop stray duplicated // on the line-121 comment; sibling line 118 already had the correct single-// form (fa17ce3).
  • lapack/base/dlarf1f: fix new indexing.json fixture using bare ints instead of .0 decimals, plus stray leading whitespace before {, to match sibling fixtures (fa17ce3).

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Findings were surfaced by a routine review of the last 24 hours of commits on develop. The audit ran two independent style-guide reviewers and two independent bug reviewers over the union diff, then re-verified every candidate against the working tree before applying. Everything requiring interpretation or a cascade beyond the touched file was deliberately excluded — see the intentionally-dropped items below.

Validation performed

  • docs/style-guides/*/README.md compliance on added/modified lines.
  • Bug scan of new-package hot spots (stats/strided/dmedian-sorted, blas/ext/base/zindex-of-truthy, the four ml/base/sgd-classification/* resolvers, three new stats/incr/* accumulators, and the lapack/base/dlarf1f off-by-one fix). No objective defects found.
  • Sibling-package convention checks (e.g. nanm* description clause, dlarf1f fixture float notation).

Deliberately excluded

  • Missing zindexOfTruthy and gger entries in the blas/ext/base and blas/base/ndarray TypeScript-declaration namespaces. The declaration files are auto-regenerated by the stdlib bot; the bot ran (c1ed55c, dda312b) before 91f035b/78c77ea added those symbols to the runtime index, so the next scheduled regeneration will close the gap without a hand-edit that could conflict.
  • Copyright-year 2020 in the migrated stats/strided/dmedian-sorted package. Rename-migrations preserve original authorship year; every file in the package carries the same date, so it's not an outlier.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code as part of a scheduled review routine over the last 24 hours of commits merged to develop. Every finding was independently re-verified against the working tree before being applied; auto-generated files and rename-migration artifacts were deliberately excluded.


@stdlib-js/reviewers


Generated by Claude Code

claude added 2 commits July 15, 2026 12:36
Align the `package.json` description with the other NaN-aware
`stats/incr` accumulators (e.g., `nanmmape`, `nanmmin`), which all
end with `, ignoring NaN values.`.
Remove a stray duplicate `//` in a trailing comment on the right-side
branch of `base.js` and reformat the `indexing.json` fixture to use
the `.0` decimal notation and top-level indentation used by every
other fixture in the directory.
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
lapack/base/dlarf1f $\\color{red}486/488$
$\\color{green}+99.59\\%$
$\\color{red}46/47$
$\\color{green}+97.87\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{red}486/488$
$\\color{green}+99.59\\%$
stats/incr/nanmmaxabs $\\color{green}148/148$
$\\color{green}+100.00\\%$
$\\color{green}9/9$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}148/148$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter
Planeshifter marked this pull request as ready for review July 15, 2026 20:28
@Planeshifter
Planeshifter requested a review from a team July 15, 2026 20:28
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jul 15, 2026
@Planeshifter

Copy link
Copy Markdown
Member Author

CI failure is due to EditorConfig download being rate-limited.

@Planeshifter
Planeshifter requested a review from kgryte July 15, 2026 20:29
@kgryte

kgryte commented Jul 16, 2026

Copy link
Copy Markdown
Member

CI failure is due to EditorConfig download being rate-limited.

When that happens, just rerun the failed job.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jul 16, 2026
@kgryte kgryte changed the title chore: follow-up cleanup for commits merged 2026-07-14..2026-07-15 chore: clean-up Jul 16, 2026
@kgryte
kgryte merged commit cdfae66 into develop Jul 16, 2026
37 of 38 checks passed
@kgryte
kgryte deleted the philipp/fix-commit-review-2026-07-15 branch July 16, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants