Repository navigation
chore: clean-up - #13487
Merged
Merged
chore: clean-up#13487
Conversation
Align the `package.json` description with the other NaN-aware `stats/incr` accumulators (e.g., `nanmmape`, `nanmmin`), which all end with `, ignoring NaN values.`.
Remove a stray duplicate `//` in a trailing comment on the right-side branch of `base.js` and reformat the `indexing.json` fixture to use the `.0` decimal notation and top-level indentation used by every other fixture in the directory.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Member
Author
|
CI failure is due to EditorConfig download being rate-limited. |
kgryte
approved these changes
Jul 16, 2026
Member
When that happens, just rerun the failed job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
developbetween 2026-07-14 15:02 UTC-7 and 2026-07-15 01:56 UTC-7 (23 commits,dc0fcd8..815a3b8).Fixes, by package:
stats/incr/nanmmaxabs:package.jsondescription was missing the trailing, ignoring NaN valuesclause every othernanm*accumulator has; appended it (5308a5e).lapack/base/dlarf1f: drop stray duplicated//on the line-121 comment; sibling line 118 already had the correct single-//form (fa17ce3).lapack/base/dlarf1f: fix newindexing.jsonfixture using bare ints instead of.0decimals, plus stray leading whitespace before{, to match sibling fixtures (fa17ce3).Related Issues
No.
Questions
No.
Other
Findings were surfaced by a routine review of the last 24 hours of commits on
develop. The audit ran two independent style-guide reviewers and two independent bug reviewers over the union diff, then re-verified every candidate against the working tree before applying. Everything requiring interpretation or a cascade beyond the touched file was deliberately excluded — see the intentionally-dropped items below.Validation performed
docs/style-guides/*/README.mdcompliance on added/modified lines.stats/strided/dmedian-sorted,blas/ext/base/zindex-of-truthy, the fourml/base/sgd-classification/*resolvers, three newstats/incr/*accumulators, and thelapack/base/dlarf1foff-by-one fix). No objective defects found.nanm*description clause,dlarf1ffixture float notation).Deliberately excluded
zindexOfTruthyandggerentries in theblas/ext/baseandblas/base/ndarrayTypeScript-declaration namespaces. The declaration files are auto-regenerated by the stdlib bot; the bot ran (c1ed55c,dda312b) before91f035b/78c77eaadded those symbols to the runtime index, so the next scheduled regeneration will close the gap without a hand-edit that could conflict.2020in the migratedstats/strided/dmedian-sortedpackage. Rename-migrations preserve original authorship year; every file in the package carries the same date, so it's not an outlier.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of a scheduled review routine over the last 24 hours of commits merged to
develop. Every finding was independently re-verified against the working tree before being applied; auto-generated files and rename-migration artifacts were deliberately excluded.@stdlib-js/reviewers
Generated by Claude Code