Skip to content

feat: add stats/base/dists/wald/mgf - #12399

Merged
Planeshifter merged 24 commits into
stdlib-js:developfrom
manit2004:wald-mgf
Aug 6, 2026
Merged

feat: add stats/base/dists/wald/mgf#12399
Planeshifter merged 24 commits into
stdlib-js:developfrom
manit2004:wald-mgf

Conversation

@manit2004

@manit2004 manit2004 commented May 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Resolves #209

Description

What is the purpose of this pull request?

This pull request:

  • Complete package for Wald mode has been implemented.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

SciPy and Julia currently doesn't have mgf for Wald or Inverse Gaussian, so I had to generate fixtures from the formula itself. Scipy Wald, Scipy Inverse Gaussian, Julia Inverse Gaussian

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

None

@stdlib-js/reviewers

manit2004 added 15 commits May 21, 2026 21:12
@manit2004
js core implementation over
e58a24d
@manit2004
js core implementation polished up
9aa49e7
@manit2004
C core implementation done
72653d9
@manit2004
draft: tests added
10a55a7
@manit2004
draft: benchmark done
6feddb9
@manit2004
added repl.txt
d3e0749
@manit2004
added test.js
ad51b35
@manit2004
examples and docs added
4a62463
@manit2004
finally done
5aa4585
@manit2004
tests fixed
3d411de
@manit2004
more issues fixed
462f4c2
@manit2004
tests t occurences fixed
e3ae737
@manit2004
spaces fixed
2551016
@manit2004
feat: add wald mgf
f48ad9d 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@manit2004
feat: add wald mgf, some small fixes
2ab7b6e 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@manit2004
manit2004 requested a review from a team May 31, 2026 10:51
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels May 31, 2026
@manit2004 manit2004 changed the title Wald mgf feat: add Wald distribution mgf package May 31, 2026
@stdlib-bot

stdlib-bot commented May 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/wald/mgf $\\color{green}314/314$
$\\color{green}+0.00\\%$ 		$\\color{green}23/23$
$\\color{green}+0.00\\%$ 		$\\color{green}4/4$
$\\color{green}+0.00\\%$ 		$\\color{green}314/314$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

manit2004 added 3 commits May 31, 2026 16:51
@manit2004
feat: add wald mgf, some linting fixes
c83a46a 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@manit2004
feat: add wald mgf, some more linting fixes
a9eeb9a 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@manit2004
feat: add wald mgf, test statement wrong
0888831 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@manit2004 manit2004 mentioned this pull request Jun 9, 2026
Closed
@manit2004 manit2004 mentioned this pull request Jul 21, 2026
Closed
@kgryte
kgryte requested a review from Planeshifter August 4, 2026 17:09
@Planeshifter Planeshifter mentioned this pull request Aug 6, 2026
Closed
@Planeshifter Planeshifter changed the title feat: add Wald distribution mgf package feat: add stats/base/dists/wald/mgf Aug 6, 2026
Planeshifter
Planeshifter reviewed Aug 6, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/wald/mgf/lib/native.js Outdated
@Planeshifter
docs: update description
5de5af4 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
chore: minor clean-up
cc2733a
Planeshifter
Planeshifter reviewed Aug 6, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/wald/mgf/docs/types/index.d.ts Outdated
@Planeshifter
style: add missing space
e456fa7 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter reviewed Aug 6, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/stats/base/dists/wald/mgf/docs/types/index.d.ts Outdated
@Planeshifter
docs: update example code
ddb71db 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
chore: minor clean-up
923d75a
Planeshifter
Planeshifter approved these changes Aug 6, 2026
View reviewed changes

@Planeshifter Planeshifter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ready to land after some minor edits. Thanks, @manit2004, for your contribution!

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Aug 6, 2026
@stdlib-bot

stdlib-bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

PR Commit Message

feat: add `stats/base/dists/wald/mgf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/12399
Closes: https://github.com/stdlib-js/stdlib/issues/209

Co-authored-by: Athan Reines <kgryte@gmail.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter
Planeshifter merged commit f1c6572 into stdlib-js:develop Aug 6, 2026
31 checks passed
@manit2004
manit2004 deleted the wald-mgf branch August 6, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RFC: add the Wald distribution

4 participants

@manit2004 @stdlib-bot @Planeshifter @kgryte