Repository navigation
chore: resolve lint errors (#12163) - #12168
SMD111-git wants to merge 3 commits into
Conversation
Removed unnecessary line breaks between fixture imports. Signed-off-by: SMD OWAIS <111645920+SMD111-git@users.noreply.github.com>
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
Hi maintainers, I fixed the reported JavaScript linting issues in this PR. However, the workflow check Check contributing guidelines acceptance appears to be failing due to repository workflow/configuration requirements rather than code changes. Please let me know if any contributor agreement or additional action is required from my side. Thank you. |
SMD111-git
left a comment
There was a problem hiding this comment.
Hi maintainers,
I fixed the reported JavaScript linting issues in this PR. However, the workflow check Check contributing guidelines acceptance appears to be failing due to repository workflow/configuration requirements rather than code changes.
Please let me know if any contributor agreement or additional action is required from my side.
Thank you.
GeoDaoyu
left a comment
There was a problem hiding this comment.
hi, I see that you have already fixed /home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/math/base/tools/hermitepoly/test/test.factory.js
There is also a file, /home/runner/work/stdlib/stdlib/lib/node_modules/@stdlib/_tools/lint/namespace-aliases/lib/resolve.js, that needs to be fixed.
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
@SMD111-git In order to move forward with this PR, you need to follow the guidance in #12168 (comment). We cannot accept this PR until you have explicitly acknowledged our contributing guidelines in your PR description. |
|
This PR still hasn't followed contributing guidance as described in #12168 (comment). Without the contribution guidelines acknowledgment, we won't be able to accept this PR. |
|
This pull request has been automatically closed because it has been inactive for an extended period after changes were requested. If you still wish to pursue this contribution, feel free to reopen the pull request or submit a new one. We appreciate your interest in contributing to stdlib! |


fix: #12163 Removed unnecessary line breaks between fixture imports.
Resolves #12163.
Description
Removed unnecessary empty lines between require() statements in:
lib/node_modules/@stdlib/math/base/tools/hermitepoly/test/test.factory.js
@stdlib-js/reviewers