Skip to content

test: migrate math/base/special/betainc to ULP-based testing - #11713

Closed
MANDEep22332 wants to merge 3 commits into
stdlib-js:developfrom
MANDEep22332:test-betainc
Closed

MANDEep22332 wants to merge 3 commits into
stdlib-js:developfrom
MANDEep22332:test-betainc

Conversation

@MANDEep22332

Copy link
Copy Markdown
Contributor

Progresses #11352

Description

What is the purpose of this pull request?

This pull request:

  • remove the old test method

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

@MANDEep22332
MANDEep22332 requested a review from a team April 22, 2026 04:35
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Apr 22, 2026
@stdlib-bot

stdlib-bot commented Apr 22, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/betainc $\color{green}110/110$
$\color{green}+0.00%$
$\color{green}7/7$
$\color{green}+0.00%$
$\color{green}1/1$
$\color{green}+0.00%$
$\color{green}110/110$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Tests Pull requests specifically adding tests. label Jun 17, 2026
@Planeshifter

Copy link
Copy Markdown
Member

Closing as superseded: math/base/special/betainc tests were already migrated to ULP-based assertions in 455dad25032 (#4037), and the package tests on develop now exclusively use the new convention. Thank you for working on this!

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants