Skip to content

chore: fix JavaScript lint errors (issue #11327)#11339

Merged
kgryte merged 3 commits intostdlib-js:developfrom
bhumikasudarshani-cmd:fix/js-lint-errors-11327
Apr 16, 2026
Merged

chore: fix JavaScript lint errors (issue #11327)#11339
kgryte merged 3 commits intostdlib-js:developfrom
bhumikasudarshani-cmd:fix/js-lint-errors-11327

Conversation

@bhumikasudarshani-cmd
Copy link
Copy Markdown
Contributor

@bhumikasudarshani-cmd bhumikasudarshani-cmd commented Apr 9, 2026

Related Issues

resolves #11327

Description

Fixed two lint errors:
-->Corrected JSDoc return value from 8t to 8Z in @stdlib/error/tools/msg2id
--> Replaced => with // returns marker in @stdlib/math/base/special/roundb test file

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Apr 9, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot
Copy link
Copy Markdown
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

Copy link
Copy Markdown
Contributor

@GeoDaoyu GeoDaoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return value is a string.

Comment thread lib/node_modules/@stdlib/error/tools/msg2id/lib/index.js Outdated
@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Apr 16, 2026
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 and removed Needs Review A pull request which needs code review. labels Apr 16, 2026
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Apr 16, 2026

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 16, 2026
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 16, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
error/tools/msg2id $\color{green}106/106$
$\color{green}+100.00%$
$\color{green}10/10$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}106/106$
$\color{green}+100.00%$
math/base/special/roundb $\color{green}203/203$
$\color{green}+100.00%$
$\color{green}24/24$
$\color{green}+100.00%$
$\color{green}2/2$
$\color{green}+100.00%$
$\color{green}203/203$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte merged commit 7431746 into stdlib-js:develop Apr 16, 2026
12 checks passed
@bhumikasudarshani-cmd bhumikasudarshani-cmd deleted the fix/js-lint-errors-11327 branch April 16, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. review: 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

4 participants