feat: add stats/strided/nancumax#11307
Open
parthodas23 wants to merge 2 commits intostdlib-js:developfrom
Open
feat: add stats/strided/nancumax#11307parthodas23 wants to merge 2 commits intostdlib-js:developfrom
stats/strided/nancumax#11307parthodas23 wants to merge 2 commits intostdlib-js:developfrom
Conversation
stdlib-bot
added
Statistics
parthodas23
force-pushed
the
rfc/stats-strided-nancumax
branch
from
b26bdd4 to
b303abc
Compare
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
added
Feature
kgryte
reviewed
Apr 17, 2026
| for ( i = min; i <= max; i++ ) { | ||
| len = pow( 10, i ); | ||
| f = createBenchmark( len ); | ||
| bench( pkg+':len='+len, f ); |
Member
There was a problem hiding this comment.
@parthodas23 Mind updating this to use string interpolation instead of concatenation? Cheers!
kgryte
reviewed
Apr 17, 2026
kgryte
reviewed
Apr 17, 2026
kgryte
reviewed
Apr 17, 2026
kgryte
reviewed
Apr 17, 2026
kgryte
reviewed
Apr 17, 2026
| for ( i = min; i <= max; i++ ) { | ||
| len = pow( 10, i ); | ||
| f = createBenchmark( len ); | ||
| bench( pkg+':ndarray:len='+len, f ); |
kgryte
reviewed
Apr 17, 2026
kgryte
reviewed
Apr 17, 2026
kgryte
reviewed
Apr 17, 2026
kgryte
reviewed
Apr 17, 2026
kgryte
reviewed
Apr 17, 2026
kgryte
reviewed
Apr 17, 2026
kgryte
reviewed
Apr 17, 2026
| * var y = toAccessorArray( [ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 ] ); | ||
| * | ||
| * var v = nancumax( 6, arraylike2object( x ), 1, 0, arraylike2object( y ), 1, 0 ); | ||
| * // returns <Object> |
Member
There was a problem hiding this comment.
This isn't a good use of doctesting, as it doesn't actually validate the implementation.
kgryte
reviewed
Apr 17, 2026
Comment on lines
+50
to
+54
| * var x = toAccessorArray( [ 2.0, 1.0, 2.0, -2.0, NaN, 4.0 ] ); | ||
| * var y = toAccessorArray( [ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 ] ); | ||
| * | ||
| * var v = nancumax( 6, arraylike2object( x ), 1, 0, arraylike2object( y ), 1, 0 ); | ||
| * // returns <Object> |
Member
There was a problem hiding this comment.
Suggested change
| * var x = toAccessorArray( [ 2.0, 1.0, 2.0, -2.0, NaN, 4.0 ] ); | |
| * var y = toAccessorArray( [ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 ] ); | |
| * | |
| * var v = nancumax( 6, arraylike2object( x ), 1, 0, arraylike2object( y ), 1, 0 ); | |
| * // returns <Object> | |
| * var x = [ 2.0, 1.0, 2.0, -2.0, NaN, 4.0 ]; | |
| * var y = [ 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 ]; | |
| * | |
| * nancumax( 6, arraylike2object( toAccessorArray( x ) ), 1, 0, arraylike2object( toAccessorArray( y ) ), 1, 0 ); | |
| * // x => [ 2.0, 2.0, 2.0, 2.0, 2.0, 4.0 ] |
kgryte
reviewed
Apr 17, 2026
Comment on lines
+75
to
+77
| if ( N <= 0 ) { | ||
| return y; | ||
| } |
Member
There was a problem hiding this comment.
This check shouldn't be here, as it is unreachable via the main export.
kgryte
reviewed
Apr 17, 2026
| } | ||
| ix = offsetX; | ||
| iy = offsetY; | ||
| max = -Infinity; |
Member
There was a problem hiding this comment.
Why are you using -Infinity? I thought we discussed this elsewhere. Namely, have a loop which searches for the first non-NaN value. Until that time, fill the output array with NaNs. Once you find the first non-NaN, set max equal to that value and then proceed as you have done below.
kgryte
reviewed
Apr 17, 2026
kgryte
reviewed
Apr 17, 2026
| } | ||
| ix = offsetX; | ||
| iy = offsetY; | ||
| max = -Infinity; |
Member
There was a problem hiding this comment.
If you start with -Infinity, how is a user supposed to distinguish between when x contains -Infinities and when it contains NaNs? The answer is they can't. That is why you need to fill with NaNs until the first non-NaN value.
kgryte
reviewed
Apr 17, 2026
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the function computes the cumulative maximum of a strided array', function test( t ) { |
Member
There was a problem hiding this comment.
You need to add test examples for when the input array starts with NaN values to demonstrate expected behavior.
kgryte
reviewed
Apr 17, 2026
| t.end(); | ||
| }); | ||
|
|
||
| tape( 'the function computes the cumulative maximum of a strided array', function test( t ) { |
kgryte
reviewed
Apr 17, 2026
kgryte
reviewed
Apr 17, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
added
Needs Changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #305 .
Description
This pull request:
stats/strided/nancumaxRelated Issues
This pull request has the following related issues:
stats/strided/nancumax#305Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers