Skip to content

feat: add blas/ext/base/gcopy-within - #10862

Merged
kgryte merged 10 commits into
stdlib-js:developfrom
headlessNode:gcopy-within
Aug 2, 2026
Merged

feat: add blas/ext/base/gcopy-within#10862
kgryte merged 10 commits into
stdlib-js:developfrom
headlessNode:gcopy-within

Conversation

@headlessNode

@headlessNode headlessNode commented Mar 10, 2026

Copy link
Copy Markdown
Member

Resolves stdlib-js/metr-issue-tracker#98.

Description

What is the purpose of this pull request?

This pull request:

  • add blas/ext/base/gcopy-within

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Primarily written by Claude Code.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 10, 2026
@stdlib-bot

stdlib-bot commented Mar 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

No coverage information available.

@headlessNode headlessNode added Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project. labels Mar 10, 2026
@headlessNode
fix: apply suggestions from code review
7632a5e 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@headlessNode
headlessNode requested a review from kgryte March 11, 2026 22:25
@headlessNode
headlessNode marked this pull request as ready for review March 11, 2026 22:25
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 11, 2026
@headlessNode
headlessNode requested a review from a team July 22, 2026 11:31
@headlessNode
fix: apply suggestions from code review
abf6771 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@headlessNode

headlessNode commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

@kgryte Ready for review.

@kgryte

kgryte commented Jul 30, 2026

Copy link
Copy Markdown
Member

As discussed, need to add workspace array support.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Jul 30, 2026
headlessNode and others added 2 commits July 30, 2026 18:04
@headlessNode
Merge branch 'develop' into gcopy-within
dfcce3d
@headlessNode
fix: apply suggestions from code review
b9099a9 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@headlessNode

headlessNode commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

@kgryte Ready for review.

@headlessNode headlessNode added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Jul 30, 2026
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Aug 2, 2026
kgryte
kgryte reviewed Aug 2, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/gcopy-within/docs/repl.txt Outdated
Stride length for `x`.

w: ArrayLikeObject
Workspace array. Must have `N` indexed elements.

@kgryte kgryte Aug 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that is likely the right guidance. Technically, w only needs as many elements as need to be copied which may be less than N, but this makes the guidance more complicated from a user POV.

kgryte
kgryte reviewed Aug 2, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/gcopy-within/docs/types/index.d.ts Outdated
kgryte
kgryte reviewed Aug 2, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/gcopy-within/docs/types/index.d.ts Outdated
kgryte
kgryte reviewed Aug 2, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/gcopy-within/docs/types/index.d.ts Outdated
kgryte
kgryte reviewed Aug 2, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/gcopy-within/docs/types/index.d.ts Outdated
kgryte
kgryte reviewed Aug 2, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/gcopy-within/docs/repl.txt Outdated
kgryte
kgryte reviewed Aug 2, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/gcopy-within/docs/repl.txt Outdated
kgryte
kgryte reviewed Aug 2, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/gcopy-within/lib/main.js Outdated
kgryte
kgryte reviewed Aug 2, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/gcopy-within/lib/main.js Outdated
kgryte
kgryte reviewed Aug 2, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/gcopy-within/lib/ndarray.js Outdated
kgryte
kgryte reviewed Aug 2, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/gcopy-within/lib/ndarray.js Outdated
kgryte
kgryte reviewed Aug 2, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/gcopy-within/README.md Outdated
@kgryte
Apply suggestions from code review
03a28cf 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Aug 2, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/gcopy-within/lib/ndarray.js
kgryte
kgryte reviewed Aug 2, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/gcopy-within/lib/ndarray.js Outdated
@kgryte
Apply suggestions from code review
9680bdd 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Aug 2, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/gcopy-within/docs/repl.txt Outdated
kgryte
kgryte reviewed Aug 2, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/gcopy-within/docs/repl.txt Outdated
kgryte
kgryte reviewed Aug 2, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/gcopy-within/README.md Outdated
kgryte
kgryte reviewed Aug 2, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/gcopy-within/README.md
@kgryte
Apply suggestions from code review
4100b00 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte reviewed Aug 2, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/gcopy-within/lib/ndarray.js
kgryte
kgryte reviewed Aug 2, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/gcopy-within/README.md Outdated
@kgryte
Apply suggestions from code review
b1e6e55 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Aug 2, 2026
View reviewed changes

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte
kgryte merged commit b91e51f into stdlib-js:develop Aug 2, 2026
30 checks passed
@headlessNode
headlessNode deleted the gcopy-within branch August 2, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. METR Pull request associated with the METR project. review: 3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: add blas/ext/base/gcopy-within

3 participants

@headlessNode @stdlib-bot @kgryte