Repository navigation
chore: fix JavaScript lint errors (issue #10528) - #10531
DebuggingMax wants to merge 2 commits into
Conversation
- Remove unused eslint-disable directives and fix array-element-newline issues in test.marsaglia.js - Replace new Array() constructor with array literal and push in benchmark.js Resolves stdlib-js#10528
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
@DebuggingMax Would you mind resolving the comment left above (#10531 (comment))? Namely, you just need to update the OP indicating you have read our contributing guidelines. Cheers! Once resolved, we can go ahead and merge this. |
|
@DebuggingMax Would you mind updating the OP as requested above? If we don't hear back in a week, I'll go ahead and mark this PR as stale and auto-close. Cheers! |
|
This pull request has been automatically closed because it has been inactive for an extended period after changes were requested. If you still wish to pursue this contribution, feel free to reopen the pull request or submit a new one. We appreciate your interest in contributing to stdlib! |
Description
This PR fixes the JavaScript lint errors reported in issue #10528.
Changes
lib/node_modules/@stdlib/stats/kstest/test/test.marsaglia.js
eslint-disable-line array-element-newlinedirectivesexpectedarray to a single line to avoid array-element-newline issueslib/node_modules/@stdlib/utils/pluck/benchmark/benchmark.js
new Array(100)andnew Array(5)constructors with array literals and push operationsRelated Issues
Resolves #10528