Repository navigation
Conversation
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
Planeshifter
left a comment
There was a problem hiding this comment.
For this PR to move forward, @Abmarne, you need to include the checkbox acknowledging the contribution guidelines.
Changes themselves here look good. Thanks!
|
This pull request has been automatically closed because it has been inactive for an extended period after changes were requested. If you still wish to pursue this contribution, feel free to reopen the pull request or submit a new one. We appreciate your interest in contributing to stdlib! |
Yes, all lint errors should be fixed.
I have verified the following:
Fixed the reported error: I replaced the usage of path.dirname with @stdlib/utils/dirname in
lib/node_modules/@stdlib/_tools/docs/www/readme-fragment-file-tree/lib/write.js
, which was the only error reported in the log ("1 problem (1 error, 0 warnings)").
Verified no other occurrences: I scanned the entire lib/node_modules directory for any other usages of path.dirname and found none.
Code Style: I ensured the new code follows the project's style conventions (e.g., spacing around arguments).