Skip to content

chore: drop constrain from wakuRequestResponse - #58

Open
weboko wants to merge 1 commit into
status-im:masterfrom
weboko:weboko/js-waku-constain
Open

chore: drop constrain from wakuRequestResponse#58
weboko wants to merge 1 commit into
status-im:masterfrom
weboko:weboko/js-waku-constain

Conversation

@weboko

@weboko weboko commented Sep 19, 2024

Copy link
Copy Markdown
Contributor

This PR remove unnecessary constrain from wakuRequestResponse.
This is needed as some protocols or cases that we want to track do not have messageHash or peerId or unique pair of both and there might be no way of pushing unique data into the table.

@vpavlin

vpavlin commented Sep 23, 2024

Copy link
Copy Markdown
Member

@weboko Hey! You will need to make the change in a new migration file (20...) as once the migration happens, the version is set in DB and the migration scripts are not re-run again.

@vpavlin

vpavlin commented Sep 23, 2024

Copy link
Copy Markdown
Member

Also, don't forget to run make generate and attache changes to bindata.go as that is actually what golang migration library uses to execute the SQL migration queries:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants