Conversation
So that we have a snapshot of the request in case Rack middleware mutates the original request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that we have a snapshot of the request in case Rack middleware mutates the original request
The problem
Rack middleware such as Rack::URLMap (used for mounting Rack apps under a path prefix) adds the prefix to
Request#env['SCRIPT_NAME'], and then clear it out once the mounted app as served a response.However, Datastar's async fibers run after the host app has returned a response, by which time the middleware has reset the script name from
'/sourced'back to''. Any code (such as template rendering) that assumes the expected path prefix (ex for URL building) will break.The solution
When initialising the Datastar Dispatcher, make sure to make a copy of the request, so that middleware mutating the original request doesn't mutate the one held by SSE fibers.