[audit] fix: bound blink.cmp version range to stay off v2 - #328
Draft
stanfish06 wants to merge 1 commit into
Draft
[audit] fix: bound blink.cmp version range to stay off v2#328stanfish06 wants to merge 1 commit into
stanfish06 wants to merge 1 commit into
Conversation
vim.version.range("1.10.0") is a single-arg open range (>= 1.10.0,
no upper bound), the same anti-pattern already flagged for fff.nvim
in #261 — so the pin doesn't actually block a future blink.cmp v2
install, despite #271 already documenting that v2 is a breaking
config-structure rewrite. Add the explicit upper bound #271
recommended but that was never applied to plugins.lua.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
plugins.lua:27pinsblink.cmpwithversion = vim.version.range("1.10.0"). A single-arg call tovim.version.range()produces an open range (>= 1.10.0, no ceiling) — the same mismatch between intent and behavior already flagged forfff.nvimin #261. In practice this means the pin does nothing to stop a futureblink.cmpv2 install.Where
lua/config/plugins.lua:27Why it matters
#271 (still open) already documents that
blink.cmpv2 is a complete config-structure rewrite (new source registration model, renamed keymap preset keys, changed completion trigger config) that will break this config'sblink.setup({...})call, and explicitly recommends pinning withvim.version.range(">= 1.0, < 2.0"). That recommendation was never applied — the code still uses the open, single-arg form. So today, the momentblink.cmpv2 tags a release,vim.packwould be free to pull it in and break completion on next sync.Fix
Mechanical, backward-compatible: no change in behavior on the current 1.x line, only adds the ceiling
#271already called for. Also added a short comment explaining why the bound exists, referencing #271.This doesn't close #271 (that issue also covers the eventual v2 migration itself) but does resolve the concrete "the pin isn't actually pinning" gap.
Generated by Claude Code