Skip to content

feat(stackablectl): check for namespace before attempting uninstall#442

Merged
sweb merged 3 commits into
mainfrom
feat/uninstall-namespace-check
Jun 1, 2026
Merged

feat(stackablectl): check for namespace before attempting uninstall#442
sweb merged 3 commits into
mainfrom
feat/uninstall-namespace-check

Conversation

@sweb
Copy link
Copy Markdown
Member

@sweb sweb commented Jun 1, 2026

Description

Checks for default namespace before attempting to uninstall.

Output looks like this:

stackablectl -s stacks/stacks-v2.yaml -d demos/demos-v2.yaml demo uninstall trino-taxi-data
An unrecoverable error occurred: failed to execute demo (sub)command

Caused by these errors (recent errors listed first):
 1: demo "trino-taxi-data" cannot be uninstalled from the "default" namespace, because Kubernetes does not allow deleting it. Pass --namespace <NAMESPACE> if the demo was installed in a different namespace, or delete the demo's resources manually

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)

Reviewer

  • Code contains useful comments
  • (Integration-)Test cases added
  • Documentation added or updated
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sweb sweb requested a review from xeniape June 1, 2026 13:14
Copy link
Copy Markdown
Member

@xeniape xeniape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just missing a changelog entry

@sweb
Copy link
Copy Markdown
Member Author

sweb commented Jun 1, 2026

LGTM just missing a changelog entry

@xeniape added changelog entry in cd1c493

@sweb sweb added this pull request to the merge queue Jun 1, 2026
@xeniape xeniape removed this pull request from the merge queue due to a manual request Jun 1, 2026
Comment thread rust/stackablectl/CHANGELOG.md
Co-authored-by: Xenia <xenia.fischer@stackable.tech>
@sweb sweb added this pull request to the merge queue Jun 1, 2026
Merged via the queue into main with commit d4ddda4 Jun 1, 2026
12 checks passed
@sweb sweb deleted the feat/uninstall-namespace-check branch June 1, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants