Repository navigation
Keep h1 descenders above the highlight and fix light accent contrast - #44
Merged
Merged
Conversation
- The h1 mark paints behind the title's other text, so letters on the line above (the y in "every", the g in "Zigbee") aren't cut off. - Light theme --color-accent-text goes from #3f7a00 to #3a7000: 4.99:1 on surface-2, up from 4.37:1, for selected chips and buttons. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A light-mode check of 15 live pages found two bugs:
/tld-directoryon phones, and the "g" and "p" in "Zigbee compatible".What changed
isolation: isolateon the h1, andz-index: -1on the mark), so letters on the line above stay readable. A highlight that is a link or holds one keeps normal painting, so the link stays clickable.--color-accent-text:#3f7a00becomes#3a7000, which gives 4.99:1 on--color-surface-2and at least 4.5:1 on every light surface. Marker art keeps its own green.Checks
/tld-directory(390px, dark) and/zigbee-devices(1440px, light).npm run qualitypasses.The light-mode check found no sideways scrolling and no console errors on any of the 15 pages.
🤖 Generated with Claude Code