Repository navigation
php: the GNU basename, and json_parser's source is .tab.c - #721
Merged
Merged
Conversation
Two stops from the first mk install, both cheap.
The rule said `mkdir -p `{basename -d $target}', which is the Plan 9
idiom for a dirname -- and inside apexp-sh the union puts APExp's own
/bin first, so basename is GNU coreutils' and has no -d. mk then
reported the failure of the compile rather than of the mkdir, naming
the victim again. The rule runs no external command now: the
directory list is known statically, mkdir -p is idempotent, and one
exec per compile is nothing beside 513 runs of pcc. Recorded as a
build-system rule, since a command name inside apexp-sh is whatever
the union resolves it to and Plan 9's own flags are the ones most
likely to be missing.
`no recipe to make ext/json/json_parser.6' had a better answer than
expected: ext/json's parser is bison-generated and the generated file
SHIPS IN THE TARBALL as json_parser.tab.c, so the object upstream
calls json_parser.lo is built from a source whose name does not match
it. One explicit rule covers it.
The useful half is what the check found rather than what it fixed.
All 513 objects were resolved against the vendored tree and this was
the only name that does not, so no bison and no re2c are needed
anywhere in this port: json_scanner.c and php_json_scanner_defs.h are
shipped too, alongside the four Zend parsers and scanners and the
4.2MB zend_vm_execute.h. A question that could have cost two more
build tools cost one grep.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WGAwvvTwDg2yknFkmZ3qzs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two stops from the first mk install, both cheap.
The rule said
mkdir -p{basename -d $target}', which is the Plan 9 idiom for a dirname -- and inside apexp-sh the union puts APExp's own /bin first, so basename is GNU coreutils' and has no -d. mk then reported the failure of the compile rather than of the mkdir, naming the victim again. The rule runs no external command now: the directory list is known statically, mkdir -p is idempotent, and one exec per compile is nothing beside 513 runs of pcc. Recorded as a build-system rule, since a command name inside apexp-sh is whatever the union resolves it to and Plan 9's own flags are the ones most likely to be missing.`no recipe to make ext/json/json_parser.6' had a better answer than expected: ext/json's parser is bison-generated and the generated file SHIPS IN THE TARBALL as json_parser.tab.c, so the object upstream calls json_parser.lo is built from a source whose name does not match it. One explicit rule covers it.
The useful half is what the check found rather than what it fixed. All 513 objects were resolved against the vendored tree and this was the only name that does not, so no bison and no re2c are needed anywhere in this port: json_scanner.c and php_json_scanner_defs.h are shipped too, alongside the four Zend parsers and scanners and the 4.2MB zend_vm_execute.h. A question that could have cost two more build tools cost one grep.
Claude-Session: https://claude.ai/code/session_01WGAwvvTwDg2yknFkmZ3qzs