chore(ci): replace SourceKnight with setup-sp - #26
Merged
Conversation
Rushaway
force-pushed
the
chore/drop-sourceknight
branch
from
August 18, 2026 08:05
e2c2ded to
efd5a55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the SourceKnight-based build (
maxime1907/action-sourceknight) with a native GitHub Actions workflow usingrumblefrog/setup-sp@v1.3.1(SourceMod 1.12.x), matching the org-wide CI migration already applied to othersrcdslabplugin repos.Plugin targets built
These 16 targets match exactly the
targets:list declared in the removedsourceknight.yaml. The_unsupported/directory (smac_eac_banlist.sp,smac_esea_banlist.sp,smac_immunity.sp) is intentionally excluded, as it was not part of the SourceKnight target list either.Dependencies
source: /addons/sourcemod/scripting/include→dest: /addons/sourcemod/scripting/includeThe
sourcemod(type: tar) dependency was dropped, as it's now provided byrumblefrog/setup-sp@v1.3.1(pinned to1.12.x).Packaging
The old workflow copied the SourceKnight package output plus
addons/sourcemod/translations/. The new workflow replicates this by packaging:addons/sourcemod/plugins/*.smxaddons/sourcemod/translations/(all locale subfolders)No other extra directories (configs/, cfg/, gamedata/, materials/, models/) exist in this repo.
Other changes
sourceknight.yaml..sourceknightentry from.gitignore..github/copilot-instructions.mdreferences from SourceKnight to the new GitHub Actions workflow.Not locally validated
Per migration guidance, this change was produced without cloning dependency repos, downloading spcomp, or compiling locally. GitHub Actions will validate the actual build on this PR.
Manual verification needed
multicolorsinclude is the only external dependency required by all 16 targets (onlysmac.spwas observed to reference it directly via grep, but transitively-included headers were not exhaustively traced).addons/sourcemod/translations/) matches downstream consumer expectations, since the previous workflow nested it undercommon/addons/sourcemod/in the packaged output structure (an artifact of the SourceKnight package layout that doesn't apply to the new flat package structure).🤖 Generated with Claude Code