Skip to content

chore(ci): replace SourceKnight with setup-sp - #26

Merged
Rushaway merged 1 commit into
masterfrom
chore/drop-sourceknight
Aug 18, 2026
Merged

chore(ci): replace SourceKnight with setup-sp#26
Rushaway merged 1 commit into
masterfrom
chore/drop-sourceknight

Conversation

@Rushaway

Copy link
Copy Markdown
Member

Summary

Replaces the SourceKnight-based build (maxime1907/action-sourceknight) with a native GitHub Actions workflow using rumblefrog/setup-sp@v1.3.1 (SourceMod 1.12.x), matching the org-wide CI migration already applied to other srcdslab plugin repos.

Plugin targets built

Target Source file
smac addons/sourcemod/scripting/smac.sp
smac_aimbot addons/sourcemod/scripting/smac_aimbot.sp
smac_autotrigger addons/sourcemod/scripting/smac_autotrigger.sp
smac_client addons/sourcemod/scripting/smac_client.sp
smac_commands addons/sourcemod/scripting/smac_commands.sp
smac_css_antiflash addons/sourcemod/scripting/smac_css_antiflash.sp
smac_css_antismoke addons/sourcemod/scripting/smac_css_antismoke.sp
smac_css_fixes addons/sourcemod/scripting/smac_css_fixes.sp
smac_cvars addons/sourcemod/scripting/smac_cvars.sp
smac_eyetest addons/sourcemod/scripting/smac_eyetest.sp
smac_hl2dm_fixes addons/sourcemod/scripting/smac_hl2dm_fixes.sp
smac_l4d2_fixes addons/sourcemod/scripting/smac_l4d2_fixes.sp
smac_rcon addons/sourcemod/scripting/smac_rcon.sp
smac_speedhack addons/sourcemod/scripting/smac_speedhack.sp
smac_spinhack addons/sourcemod/scripting/smac_spinhack.sp
smac_wallhack addons/sourcemod/scripting/smac_wallhack.sp

These 16 targets match exactly the targets: list declared in the removed sourceknight.yaml. The _unsupported/ directory (smac_eac_banlist.sp, smac_esea_banlist.sp, smac_immunity.sp) is intentionally excluded, as it was not part of the SourceKnight target list either.

Dependencies

Name Repo URL Unpack path (from sourceknight.yaml)
multicolors https://github.com/srcdslab/sm-plugin-MultiColors source: /addons/sourcemod/scripting/includedest: /addons/sourcemod/scripting/include

The sourcemod (type: tar) dependency was dropped, as it's now provided by rumblefrog/setup-sp@v1.3.1 (pinned to 1.12.x).

Packaging

The old workflow copied the SourceKnight package output plus addons/sourcemod/translations/. The new workflow replicates this by packaging:

  • addons/sourcemod/plugins/*.smx
  • addons/sourcemod/translations/ (all locale subfolders)

No other extra directories (configs/, cfg/, gamedata/, materials/, models/) exist in this repo.

Other changes

  • Removed sourceknight.yaml.
  • Removed the now-unused .sourceknight entry from .gitignore.
  • Updated .github/copilot-instructions.md references from SourceKnight to the new GitHub Actions workflow.

Not locally validated

Per migration guidance, this change was produced without cloning dependency repos, downloading spcomp, or compiling locally. GitHub Actions will validate the actual build on this PR.

Manual verification needed

  • Confirm the multicolors include is the only external dependency required by all 16 targets (only smac.sp was observed to reference it directly via grep, but transitively-included headers were not exhaustively traced).
  • Confirm the translations packaging path (addons/sourcemod/translations/) matches downstream consumer expectations, since the previous workflow nested it under common/addons/sourcemod/ in the packaged output structure (an artifact of the SourceKnight package layout that doesn't apply to the new flat package structure).

🤖 Generated with Claude Code

Copilot AI lite review requested due to automatic review settings August 17, 2026 13:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Rushaway
Rushaway force-pushed the chore/drop-sourceknight branch from e2c2ded to efd5a55 Compare August 18, 2026 08:05
@Rushaway
Rushaway merged commit 77bfe8a into master Aug 18, 2026
6 checks passed
@Rushaway
Rushaway deleted the chore/drop-sourceknight branch August 18, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants