Fix BatchOperations.create_index typing - #1855
Closed
Boulea7 wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Thanks! Issue #1853 is now marked code review in progress and no longer open for pull requests, so this pull request holds the review for it and another one won't land on top of your work. If this pull request is abandoned, a maintainer can put open for pull requests back on #1853 to reopen it to others. |
sqla-tester
reviewed
Aug 14, 2026
sqla-tester
left a comment
sqla-tester
left a comment
Collaborator
There was a problem hiding this comment.
OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision 36a42d5 of this pull request into gerrit so we can run tests and reviews and stuff
Collaborator
|
New Gerrit review created for change 36a42d5: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/6897 |
Collaborator
|
Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/6897 has been merged. Congratulations! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1853
Description
Update
BatchOperations.create_index()so its generated API accepts the same column expression types asOperations.create_index(). This removes false type-checker errors for batch migrations that use expressions such asliteral_column().The
BatchOperationsAPI was regenerated withtools/write_pyi.py. Generated-stub consistency, the repository mypy check, and the SQLite test suite pass.