-
Notifications
You must be signed in to change notification settings - Fork 66
chore: release v1.0.0 - ESM-only, analytical antimeridian splitting, fix antimeridian low npoints split #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
5f58c4f
test: add antimeridian splitting tests for low npoints values
thomas-hervey cc9037e
fix(great-circle): replace GDAL heuristic with analytical antimeridia…
thomas-hervey d3598f2
test(antimeridian): assert exactly 2 segments at antimeridian split
thomas-hervey cbf2c4e
test(integration): replace brittle snapshots with semantic assertions
thomas-hervey a27ad91
chore: remove GDAL attribution now that heuristic is replaced
thomas-hervey 19c506a
Merge pull request #76 from thomas-hervey/test/antimeridian-low-npoints
thomas-hervey 807167d
docs: fix stale ArcOptions.offset JSDoc and DEVELOPING.md scripts
thomas-hervey 98d42e7
chore: remove deprecated offset usage from tests, README, and demo
thomas-hervey 496efc6
feat(great-circle): default npoints to 100
thomas-hervey 6e9178d
refactor(tests): extract shared route fixtures to test/fixtures/
thomas-hervey 970148d
chore(scripts): add dump-fixtures for visual route verification
thomas-hervey b154d4d
chore(scripts): add benchmark comparing bisection vs linear interpola…
thomas-hervey b4a8d1d
refactor(great-circle): extract bisection constant and add inline com…
thomas-hervey 48fc6d6
Merge pull request #77 from thomas-hervey/docs/arc-options-cleanup
thomas-hervey 86e5376
chore: bump version to 1.0.0 and update CHANGELOG
thomas-hervey f2a3623
docs(readme): show npoints is optional, defaults to 100
thomas-hervey c5ea41a
fix: address jgravois review comments on PR #79
thomas-hervey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a note that we need to add
src/to the files array before we publish. doesn't matter to me whether that happens here or a follow-up PR.when we do that, we should update the DEVELOPING.md file too.
https://github.com/springmeyer/arc.js/blob/f2a36235e11897d7a211c4cb20429e4fdd578361/DEVELOPING.md#what-gets-published
ref: #80
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's roll this into the release, so I'll make those changes in the next commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in c5ea41a.